[BOOKINGSG-9309][GZ] migrate language switcher to linaria css#1172
Merged
Conversation
ghazwan-gt
requested review from
iant-gds,
qroll,
ryan-nguyen-t,
zhaoyanxzy and
ziggyzet
ziggyzet
reviewed
May 13, 2026
| ref={setFloatingRef} | ||
| style={{ ...styles, width: elementWidth }} | ||
| className={styles.dropdownPanel} | ||
| style={{ ...floatingStyles, width: elementWidth }} |
There was a problem hiding this comment.
hmm so floatingStyles, we probably can just leave it be but for elementWidth we probably should still use the useApplyStyles hook. can create a new ref to set it and merge it with the floatingRef
qroll
requested changes
May 14, 2026
qroll
approved these changes
May 14, 2026
ghazwan-gt
force-pushed
the
BOOKINGSG-9309/language-switcher
branch
from
33d0434 to
bd2ec4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
classNameis chained correctly withclsx