[BOOKINGSG-9284][ZZ] refactor: migrate date range input to linaria#1177
Open
ziggyzet wants to merge 8 commits into
Open
[BOOKINGSG-9284][ZZ] refactor: migrate date range input to linaria#1177ziggyzet wants to merge 8 commits into
ziggyzet wants to merge 8 commits into
Conversation
Co-authored-by: Copilot <copilot@github.com>
… linaria Co-authored-by: Copilot <copilot@github.com>
…tories Co-authored-by: Copilot <copilot@github.com>
ziggyzet
requested review from
ghazwan-gt,
iant-gds,
qroll,
ryan-nguyen-t and
zhaoyanxzy
qroll
reviewed
May 14, 2026
| // ============================================================================= | ||
| // STYLING | ||
| // ============================================================================= | ||
| export const container = css``; |
Contributor
There was a problem hiding this comment.
can remove this empty css style
ghazwan-gt
reviewed
May 14, 2026
There was a problem hiding this comment.
This is is being blocked by the dropdown
qroll
requested changes
May 15, 2026
Contributor
There was a problem hiding this comment.
hmm why the background for the input still white in dark mode?
Comment on lines
+100
to
+111
| await expect(story.locators.defaultFormInput).toMatchAriaSnapshot(` | ||
| - group "Default" | ||
| `); | ||
| await expect(story.locators.disabledFormInput).toMatchAriaSnapshot(` | ||
| - group "Disabled" [disabled] | ||
| `); | ||
| await expect(story.locators.readonlyFormInput).toMatchAriaSnapshot(` | ||
| - group "Readonly" | ||
| `); | ||
| await expect(story.locators.errorFormInput).toMatchAriaSnapshot(` | ||
| - group "Error" | ||
| `); |
Contributor
There was a problem hiding this comment.
also include the child elements (textbox) like what was done for date-input
| await story.init("form-variants", { size: "mobile" }); | ||
| }); | ||
|
|
||
| test("Form.DateRangeInput variants (mobile)", async ({ story }) => { |
Contributor
There was a problem hiding this comment.
can we also include a snapshot of the calendar open state on mobile? this is to ensure the dropdown looks ok on smaller widths
| }); | ||
| }); | ||
|
|
||
| test.describe("Disabled", () => { |
Contributor
There was a problem hiding this comment.
can be removed since it's covered by the form variants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
classNameis chained correctly withclsx- [ ] Updated Storybook documentation- [ ] Added/updated unit tests- [ ] Listed breaking changes