Upgrade to node 22#594

Merged

qroll merged 9 commits into

mainfrom

May 15, 2026

Contributor

benjaminLeongSK commented May 5, 2026

Changes
Upgrading of node version

[delete] branch

Changelog entry

Fix audit issues
Bump dependencies
Replace deprecated test functions

Additional information

You may refer to this CCUBE-1804
For vulnerabilities in Dependabot alerts will have to wait till this branch is merged in for it to be updated and tackled

benjaminLeongSK requested a review from qroll

May 5, 2026 01:50

qroll previously approved these changes

View reviewed changes

qroll dismissed their stale review

May 5, 2026 08:12

wrong repo

benjaminLeongSK force-pushed the BL/1804 branch from 1e07073 to a1dbe86 Compare

May 6, 2026 08:31

qroll requested changes

View reviewed changes

rollup.config.js

scripts/patch-jsdom.js Outdated

src/__tests__/components/fields/file-upload/file-upload.spec.tsx

package-lock.json

src/components/fields/image-upload/image-review/image-editor/image-editor.tsx Outdated

benjaminLeongSK commented

View reviewed changes

src/components/fields/image-upload/image-review/image-editor/image-editor.tsx

benjaminLeongSK commented

View reviewed changes

src/components/fields/image-upload/image-review/image-editor/image-editor.tsx

benjaminLeongSK commented

View reviewed changes

src/components/fields/image-upload/image-review/image-editor/image-editor.tsx

benjaminLeongSK commented

View reviewed changes

src/components/fields/image-upload/image-review/image-editor/image-editor.tsx

benjaminLeongSK commented

View reviewed changes

src/components/fields/image-upload/image-review/image-editor/image-editor.tsx

benjaminLeongSK commented

View reviewed changes

src/components/fields/image-upload/image-review/image-editor/image-editor.tsx Outdated

benjaminLeongSK commented

View reviewed changes

src/components/fields/image-upload/image-review/image-editor/image-editor.tsx

Contributor Author

benjaminLeongSK commented May 6, 2026

the canvas changes avoid direct viewportTransform mutation and use Fabric's public APIs (setDimensions, centerObject, setZoom, absolutePan) instead. pan is tracked separately so zoom and drag can be clamped consistently

qroll reviewed

View reviewed changes

src/components/fields/image-upload/image-review/image-editor/image-editor.tsx Outdated

weili-govtech self-requested a review

May 7, 2026 06:44

weili-govtech previously requested changes

View reviewed changes

src/components/fields/image-upload/image-review/image-editor/image-editor.tsx Outdated

src/components/fields/image-upload/image-review/image-editor/image-editor.tsx

src/components/fields/image-upload/image-review/image-editor/image-editor.tsx Outdated

package.json Outdated

benjaminLeongSK force-pushed the BL/1804 branch from 70a132d to 54a3c89 Compare

May 11, 2026 07:05

benjaminLeongSK added 7 commits

May 12, 2026 09:09


          [#1804][BL] Upgrade to node 22

047819d


          [#1804][BL] Update dependencies and added jsdom patch for test cases

1b8bc49


          [#1804][BL] Update deprecated test assertions

737a788


          [#1804][BL] Amend failing logic due to version update

3cfe476


          [#1804][BL] Amend MR comments

e5090e3


          [#1804][BL] Fix bug where zooming cause drawing to disappear

24c3eb1


          [#1804][BL] Create custom typing for fabric erasable

7d6ceed

benjaminLeongSK force-pushed the BL/1804 branch from 54a3c89 to 262d88f Compare

May 12, 2026 01:13

qroll previously approved these changes

View reviewed changes

qroll reviewed

View reviewed changes

src/components/fields/image-upload/image-review/image-editor/image-editor.tsx

qroll reviewed

View reviewed changes

.storybook/main.ts


          [#1804][BL] Amend MR comments and sync lock file

788ca6c

benjaminLeongSK dismissed qroll’s stale review via

788ca6c

May 13, 2026 01:23

benjaminLeongSK force-pushed the BL/1804 branch from 262d88f to 788ca6c Compare

May 13, 2026 01:23


          [#1804][BL] Fix drawing going out of bounds

b4f5a94

qroll approved these changes

View reviewed changes

qroll requested a review from weili-govtech

May 14, 2026 02:30

qroll dismissed weili-govtech’s stale review

May 15, 2026 03:05

comments resolved

qroll merged commit 6f496b4 into main

1 check passed

qroll deleted the BL/1804 branch

May 15, 2026 03:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet