fix(runtime): warn on stranded tasks after drain timeout - #272
Merged
David-patrick-chuks-02 merged 2 commits intoSep 6, 2026
Merged
Conversation
David-patrick-chuks-02
merged commit Sep 6, 2026
abee3d4
into
Lilly-Protocol:main
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentRuntime.stop()previously finished silently when a positive drain timeout expired with tasks still running.This change emits one warning through the configured runtime logger after draining returns when tasks remain in flight. Warning metadata includes
runtimeId,taskIds,inFlightTaskCount,drainTimeoutMs, anddrainElapsedMs.Omitted/zero timeout and successful-drain behavior remain unchanged. Focused runtime tests pass 22/22, and full
npm run verifypasses 55 files / 230 tests. Untouched-main verification passes 55 files / 226 tests.No #259 promise-tracking redesign is included.
Fixes #258