Skip to content

fix(actions): reject non-finite amount values in createPaymentPrepTool (Closes #239) - #277

Merged
David-patrick-chuks-02 merged 2 commits into
Lilly-Protocol:mainfrom
Ranjeet2063:fix/reject-non-finite-payment-prep-amounts
Sep 6, 2026
Merged

fix(actions): reject non-finite amount values in createPaymentPrepTool (Closes #239)#277
David-patrick-chuks-02 merged 2 commits into
Lilly-Protocol:mainfrom
Ranjeet2063:fix/reject-non-finite-payment-prep-amounts

Conversation

@Ranjeet2063

Copy link
Copy Markdown
Contributor

Summary

Addresses issue #239 by validating that values supplied to are finite numbers.

Changes

  1. Validation:
    • Added to the guard in .
    • Prevents non-finite inputs like , , , and from passing validation and slipping into the transaction-stub path.
    • Throws .
  2. Tests:
    • Added unit test in verifying that , , , , and non-finite strings properly reject with code .
    • All 7 tests in pass cleanly.

Closes #239.

Copilot AI lite review requested due to automatic review settings September 3, 2026 09:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@David-patrick-chuks-02
David-patrick-chuks-02 merged commit d4016ab into Lilly-Protocol:main Sep 6, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bounty: $70] Reject non-finite amount values in createPaymentPrepTool

4 participants