fix(runtime): reject duplicate in-flight task IDs (#257) - #343
Merged
David-patrick-chuks-02 merged 2 commits intoSep 6, 2026
Merged
Conversation
David-patrick-chuks-02
merged commit Sep 6, 2026
91b4fd2
into
Lilly-Protocol:main
0 of 2 checks passed
Contributor
Author
|
Thanks for merging this. Could you confirm whether there is anything else required from me to complete the bounty settlement/payment, and what the next step is? If payout details are needed, please point me to the appropriate official/private route. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #257 by rejecting a second
executeTask()invocation while the same task ID is already active. The duplicate call fails with typedDUPLICATE_IN_FLIGHT_TASKbefore duplicate tool execution or duplicate failed lifecycle events can occur. Task IDs can be reused after the previous execution settles.Regression coverage launches concurrent duplicate IDs, checks the typed error and active task count, confirms no duplicate
runtime.task.failedevent, and verifies reuse after settlement.Verification
The initial isolated run exposed two TypeScript defects in the test. Those were repaired. The exact final patch then passed the repository's complete
npm run verifygate with formatting, ESLint, TypeScript, Vitest and coverage under network-disabled repository execution.This is an independent competing submission for the still-open bounty.
Closes #257