fix: reconcile ActionExecutor merge conflicts and restore regressions - #390
Open
MyTH-zyxeon wants to merge 1 commit into
Open
Conversation
Run-Id: run-f340b98b-3e70-4cba-b543-e9bcd5e5b105 Trace-Id: cd0b1e2ac2394d3b873fc5b937def716 Requester: scheduled monitor-sxt-bounty-pr-1757 Implementer: MISA 3 bot ID 1516725819517567077
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Follow-up to #368 and the tool-budget behavior discussed in #256. The final merged #368 diff retained only imports, not its original regression cases. On current main
79af57bb39926d672b3595e66286df7ed85c0e9d, ActionExecutor cannot transform becausetoolis declared twice. It also references undefined constructor variables, callsToolDefinition.executewith the wrong argument shape, and emits event names absent fromRuntimeEventMap.This two-file repair reconciles only ActionExecutor:
{ payload, context }, retain the typedruntime.tool.invokedevent and its timestamp, and restore existing completion duration logging. No new event types or logging are introduced.Validation
vitest run tests/action-executor.test.tscannot collect tests due to duplicatetooldeclaration. TypeScript reports constructor, tool-call and event-contract errors in ActionExecutor.vitest run tests/actions/action-executor-merge-regression.test.ts tests/actions/log-tool-duration.test.ts tests/actions/tool-call-budget.test.ts tests/events/tool-invoked.test.ts: 21 tests passed across 4 files.tsc --noEmitreports 48 errors outside the changed files. Full Vitest: 55 failed files / 36 passed; 12 failed tests / 212 passed. Unrelated duplicate declarations in memory/runtime and conflicting event/logger tests remain untouched. This PR does not claim to make all CI green.AI-assisted implementation, with local reproduction and tests. This is a corrective follow-up, not an exclusive bounty claim or a claim that an award/payment is due. The amount advertised on #256 remains unverified for sponsor approval and eligibility.
Run-Id:
run-f340b98b-3e70-4cba-b543-e9bcd5e5b105Trace-Id:
cd0b1e2ac2394d3b873fc5b937def716Requester: scheduled automation
monitor-sxt-bounty-pr-1757(Discord sender metadata not supplied)Implementer: MISA 3 bot ID
1516725819517567077