Skip to content

fix(windows): restore rounded leading navigation surface - #238

Open
LimiNode wants to merge 1 commit into
mainfrom
fix/navigation-strip-first-item-corner
Open

LimiNode wants to merge 1 commit into
mainfrom
fix/navigation-strip-first-item-corner

Conversation

@LimiNode

@LimiNode LimiNode commented Sep 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • restore the NavigationStrip leading item's rounded bottom-left presentation;
  • make the title-region own the stable bottom-left corner while the side seam stays square;
  • keep activation, keyboard navigation, and text layout delegated to Dear ImGui's MenuItem;
  • use Dear ImGui's actual item rectangle for the optional leading-item mask;
  • keep title-bar geometry and theme colors owned by ImGuiX.

Verification

  • cmake --build external/ImGuiX/build-mingw --target imguix --parallel 36
  • cmake --build build-mingw --target mgc-gui --parallel 36
  • ImGuiX CTest: 15/15 passed
  • mgc-platform CTest: 17/17 passed
  • manual PrintWindow smoke capture confirms the rounded System surface

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d3967dffab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +360 to +365
ImGui::GetWindowDrawList()->AddRectFilled(
rect_min,
rect_max,
ImGui::GetColorU32(surface),
radius,
ImDrawFlags_RoundCornersBottomLeft);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the navigation-strip seam square

When the leading navigation item is selected, hovered, or held, this manually painted bottom-left-rounded surface replaces the regular MenuItem header and makes the title/body junction rounded. The canonical NavigationStrip behavior requires that junction to remain square and explicitly relies on the regular themed MenuItem surface rather than a second rounded overlay, so this produces incorrect chrome in every active first-item state; remove the overlay and retain the normal header rendering.

AGENTS.md reference: AGENTS.md:L265-L273

Useful? React with 👍 / 👎.

Keep the title region responsible for the stable bottom-left corner and use Dear ImGui's actual first MenuItem rectangle for the optional navigation surface mask.
@LimiNode
LimiNode force-pushed the fix/navigation-strip-first-item-corner branch from bc334e0 to ce15b1e Compare September 14, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant