Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3967dffab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ImGui::GetWindowDrawList()->AddRectFilled( | ||
| rect_min, | ||
| rect_max, | ||
| ImGui::GetColorU32(surface), | ||
| radius, | ||
| ImDrawFlags_RoundCornersBottomLeft); |
There was a problem hiding this comment.
Keep the navigation-strip seam square
When the leading navigation item is selected, hovered, or held, this manually painted bottom-left-rounded surface replaces the regular MenuItem header and makes the title/body junction rounded. The canonical NavigationStrip behavior requires that junction to remain square and explicitly relies on the regular themed MenuItem surface rather than a second rounded overlay, so this produces incorrect chrome in every active first-item state; remove the overlay and retain the normal header rendering.
AGENTS.md reference: AGENTS.md:L265-L273
Useful? React with 👍 / 👎.
Keep the title region responsible for the stable bottom-left corner and use Dear ImGui's actual first MenuItem rectangle for the optional navigation surface mask.
bc334e0 to
ce15b1e
Compare
Summary
MenuItem;Verification
cmake --build external/ImGuiX/build-mingw --target imguix --parallel 36cmake --build build-mingw --target mgc-gui --parallel 36PrintWindowsmoke capture confirms the rounded System surface