fix(http): make response callbacks exception-safe - #40
Merged
Merged
Conversation
Centralize HTTP response callback invocation so terminal cleanup always runs, isolate completion callbacks from each other, and cover callback failures and post-shutdown waiter registration.\n\nConstraint: Preserve C++11 compatibility and final-callback-before-group-idle ordering.\nRejected: Duplicating try/catch completion guards across terminal paths.\nDirective: Route new terminal HTTP response paths through invoke_final_callback().\nConfidence: high\nScope-risk: moderate
Use the centralized callback boundary for streaming response chunks and narrow the concurrency documentation to HTTP response and completion callbacks.\n\nConstraint: Preserve streaming callback timing and C++11 compatibility.\nRejected: Keep a second streaming-only exception path with different non-std exception handling.\nConfidence: high\nScope-risk: narrow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification