Skip to content

fix vcf FILTER column name#10

Merged
GFJHogue merged 14 commits intoLincolnSteinLab:mainfrom
oicr-gsi:gavin_updates
Dec 17, 2025
Merged

fix vcf FILTER column name#10
GFJHogue merged 14 commits intoLincolnSteinLab:mainfrom
oicr-gsi:gavin_updates

Conversation

@gavin-peng
Copy link
Copy Markdown
Contributor

utils.py line 191: vcf['FILTER_PASS'] == True)
this is filtering for a column called "FILTER_PASS". from what I can see in our vcf file, the column is just called FILTER, and the values are "PASS".
so the original filter condition will filter out all the variants, I guess that's the reason all the DeepTumour results give same prediction of cancer type regardless of inputs.
The fix added the condition for column name "FILTER".

@GFJHogue GFJHogue self-requested a review December 15, 2025 15:46
Copy link
Copy Markdown
Collaborator

@GFJHogue GFJHogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this changes the behaviour for some VCF files, then there is likely a bug with scikit-allel. It's supposed to automatically create the FILTER_PASS column and populate it with True for all PASSing rows.

If this is indeed working around broken behaviour, then this change looks reasonable @gavin-peng

@gavin-peng
Copy link
Copy Markdown
Contributor Author

If this changes the behaviour for some VCF files, then there is likely a bug with scikit-allel. It's supposed to automatically create the FILTER_PASS column and populate it with True for all PASSing rows.

If this is indeed working around broken behaviour, then this change looks reasonable @gavin-peng

thanks Greg!

@GFJHogue GFJHogue merged commit a02effe into LincolnSteinLab:main Dec 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants