fix vcf FILTER column name#10
Merged
GFJHogue merged 14 commits intoLincolnSteinLab:mainfrom Dec 17, 2025
Merged
Conversation
deal with boundary variants
GFJHogue
reviewed
Dec 15, 2025
Collaborator
GFJHogue
left a comment
There was a problem hiding this comment.
If this changes the behaviour for some VCF files, then there is likely a bug with scikit-allel. It's supposed to automatically create the FILTER_PASS column and populate it with True for all PASSing rows.
If this is indeed working around broken behaviour, then this change looks reasonable @gavin-peng
Contributor
Author
thanks Greg! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utils.py line 191: vcf['FILTER_PASS'] == True)
this is filtering for a column called "FILTER_PASS". from what I can see in our vcf file, the column is just called FILTER, and the values are "PASS".
so the original filter condition will filter out all the variants, I guess that's the reason all the DeepTumour results give same prediction of cancer type regardless of inputs.
The fix added the condition for column name "FILTER".