add icu-uc, build on Fedora 42#501
Open
YaoFei509 wants to merge 1 commit intoLinearTapeFileSystem:masterfrom
Open
add icu-uc, build on Fedora 42#501YaoFei509 wants to merge 1 commit intoLinearTapeFileSystem:masterfrom
YaoFei509 wants to merge 1 commit intoLinearTapeFileSystem:masterfrom
Conversation
piste-jp
suggested changes
Apr 7, 2025
Contributor
piste-jp
left a comment
piste-jp
left a comment
There was a problem hiding this comment.
I believe L.355 shall be fixed.
| ICU_MODULE_VERSION="`pkg-config --modversion icu-i18n 2> /dev/null`"; | ||
| ICU_MODULE_CFLAGS="`pkg-config --cflags icu-i18n 2> /dev/null`"; | ||
| ICU_MODULE_LIBS="`pkg-config --libs icu-i18n 2> /dev/null`"; | ||
| ICU_MODULE_CFLAGS="`pkg-config --cflags icu-i18n icu-uc2> /dev/null`"; |
Contributor
There was a problem hiding this comment.
configure script reports below.
Package icu-uc2 was not found in the pkg-config search path.
Perhaps you should add the directory containing `icu-uc2.pc'
to the PKG_CONFIG_PATH environment variable
Package 'icu-uc2', required by 'virtual:world', not found
I think this line shall be
ICU_MODULE_CFLAGS="`pkg-config --cflags icu-i18n icu-uc 2> /dev/null`";
Contributor
There was a problem hiding this comment.
Not updated correctly....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This pull request includes following changes or fixes.
Description
Please include relevant motivation and context. List any dependencies that are required for this change.
Fixes #issue_no
Type of change
Please delete items that are not relevant.
Checklist: