fix: only logging when level permits it on Windows#569
Open
Piloalucard wants to merge 1 commit intoLinearTapeFileSystem:v2.4.8-windows-supportfrom
Open
fix: only logging when level permits it on Windows#569Piloalucard wants to merge 1 commit intoLinearTapeFileSystem:v2.4.8-windows-supportfrom
Piloalucard wants to merge 1 commit intoLinearTapeFileSystem:v2.4.8-windows-supportfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This pull request includes following changes or fixes.
Description
On Windows platform, logs of LTFS were not properly set up, every message is logged causing a performance issue when using LTFS with logs enabled. To fix this, a conditional was added to log only messages permitted by the log level set.
Type of change
Checklist: