fix(mail): soften transient liveness bounces#940
Open
BatalloLu wants to merge 1 commit into
Open
Conversation
Retry the same heartbeat liveness predicate briefly before refusing filesystem mail delivery, and report heartbeat-based deliverability uncertainty instead of declaring the agent not running. Add tests for no heartbeat, stale heartbeat, and transient stale heartbeat recovery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The observed email bounce versus later CPR result is best explained by a transient heartbeat observation, not two wholly different predicates.
Both paths use the same Core presence predicate for non-human agents: the target must have an agent manifest and a fresh heartbeat under the default two-second threshold.
The previous email path sampled that predicate once in PosixFilesystemMailAdapter.send(). If the one sample failed, the mailman reported "Agent at ... is not running" and emitted an email.bounce. CPR sampled the same predicate later; when heartbeat was fresh by then, system.cpr correctly returned "already running".
Fix
Evidence included in investigation
Validation
Result: 91 passed in 14.78s.
Out of scope