fix(vision): route standalone vision through native providers#957
Closed
huangzesen wants to merge 4 commits into
Closed
fix(vision): route standalone vision through native providers#957huangzesen wants to merge 4 commits into
huangzesen wants to merge 4 commits into
Conversation
Collaborator
Author
|
Superseded by #964, which carries the latest-main implementation and the complete current provider/preset coverage for Lingtai-AI/lingtai#957. Thank you for establishing the original Codex/Codex-pool vision direction here; that work is preserved and extended in the replacement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex-poolandcodex_poolas native Codex vision aliases and route the Codex family through the existing Responsesinput_imageservicemimo-v2.5by default) while preserving its same-provider endpoint; do not forward text-only MiMo chat modelsglmto the existing Zhipu MCP vision service; keep MiniMax/Zhipu MCP routing unchangedScope
This PR keeps the existing explicit
vision(image_path, question)tool. It does not add canonical main-session image blocks, auto-enable omitted optional capabilities, infer whether a relay/upstream model accepts images, install/download a local model, or introduce any silent cross-provider fallback.MiniMax and Zhipu remain explicitly configured MCP-backed services. Built-in preset declarations/editor choices are owned by the TUI repository; this kernel PR makes declared vision capabilities route correctly but does not silently turn on vision for a TUI preset that omits it (notably the current Gemini preset source).
Validation
Parent-run validation on exact head
d8abcdc772e88228ce5efcf07f6c3526f8f1fd11:/Users/huangzesen/work/GitHub/lingtai-kernel/.venv/bin/python -m pytest tests/test_vision_capability.py tests/test_vision_services.py -q— 56 passed/Users/huangzesen/work/GitHub/lingtai-kernel/.venv/bin/python -m pytest tests/test_codex_pool*.py -q— 109 passed/Users/huangzesen/work/GitHub/lingtai-kernel/.venv/bin/python -m pytest tests/test_architecture_documents.py tests/test_anatomy_drift_checker.py -q— 12 passed/Users/huangzesen/work/GitHub/lingtai-kernel/.venv/bin/python -m lingtai.tools.glossary_validator --check— 54 resources validatedpy_compile, lazy-import smoke (lingtai.tools.visiondoes not importlingtai.services), andgit diff --check— passedLive evidence and safety
After the initial Codex production commit
0a9fdfc66f004068477cc6394812ac8c4e09e598, one explicitly authorized controlled PNG smoke through the activecodex-pool/gpt-5.6-solroute returned the exact red/yellow/white/blue geometry. The broader provider expansion was validated only with mocked/local tests: there were no live OpenAI, Anthropic, Gemini, MiMo, MiniMax, or Zhipu calls.The current live runtime remains on
0a9fdfc6; this expanded PR head was not installed or refreshed. No auth/config mutation, credential-file inspection, fallback-provider call, dependency change, or local model download was performed.