refactor(tui): add accepted mail snapshot seam#663
Open
TZZheng wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProjectMailSnapshotboundary between the mutable refresh producer cache and mail consumersRefs #645.
Scope
This is deliberately the narrow accepted-snapshot seam, not the later root-store migration. It retains the existing producer refresh/tick path and does not add
ProjectMailStore, cancellation, mutexes, tickers, scan serialization, or portal changes.Sequence zero remains a compatibility/test envelope only; every production scheduling path now uses the reserved nonzero request flow.
Test-first evidence
Focused contract tests were written and run before the production repair. Their semantic RED covered:
The same contracts pass at the exact published head.
Validation
Exact head:
f9ef7c97f9266a77c9427793e91c7bd691907eedgo test ./internal/fs ./internal/tui -count=1 -timeout=120sgo test . -count=1 -timeout=120s-racego vet ./internal/fs ./internal/tuigo test -race ./internal/fs ./internal/tui -skip '^TestPortalURLTimeoutKillsChild$' -count=1 -timeout=240sAll commands above pass. The literal full aggregate race command fails only the existing
TestPortalURLTimeoutKillsChildPID-timing test; the identical failure was reproduced with the identical command on pristine basee8eba005, with no race-detector finding and no failure in this change's packages/contracts.Independent exact-head reviews:
gpt-5.6-sol/ high effort: PASS