ci: add GitHub Actions workflow - #8
Merged
Merged
Conversation
Flutter 3.47 rewrites `analysis_options.yaml` on `pub get` to exclude the build and platform directories, which leaves a dirty tree on any machine running a current stable SDK. Commit the migrated files so the repo is already in the state the tool wants.
This repo had no CI, so pull requests merged unverified while the iOS and Android SDKs both gate on tests and lint. Four jobs, mirroring the other SDK repos: unit tests with coverage, analyze plus a format check, a guard that the committed *.g.dart sources match what build_runner produces, and a `pub publish --dry-run` package validation gated behind the other three.
onamfc
force-pushed
the
ci/flutter-workflow
branch
from
August 15, 2026 21:49
a6cb8c4 to
3dd3fe0
Compare
dart format --set-exit-if-changed is one of the gates this workflow adds, and it fails on main as it stands: a line wrap in deep_link_data_test.dart and two trailing blank lines in url_parser_test.dart, both from the passthrough fix in 5f68a33, which shipped with no CI to catch them. A PR that introduces a gate should leave the tree passing it, so the fix rides along here rather than landing the workflow red.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo has no CI, so pull requests merge unverified — the iOS and Android SDK repos both gate on tests and lint. Noticed while porting the
deepLinkDatafix (#7), which reported no checks.The workflow
Four jobs, mirroring the other SDK repos:
flutter test --coverage, uploadslcov.infoflutter analyze+dart format --set-exit-if-changedbuild_runnerand fails if committed*.g.dartdiffersflutter pub publish --dry-run, gated behind the other threeThe Generated Code job is the one that isn't just parity with the other repos: the
*.g.dartfiles are committed, so a model change without a rebuild would silently ship stale serialization — exactly the layer #7 touches.Uses
subosito/flutter-action@v2on the stable channel with caching — the standard action for Flutter CI, and the closest analogue togradle/actions/setup-gradlein the Android repo.The analysis_options commit
The first run failed the Package job, and the cause was real rather than a workflow bug: CI's Flutter (3.47) rewrites
analysis_options.yamlonpub getto exclude the build and platform directories, which dirties the tree and trips the publish validator's clean-git-state check. Local dev on 3.44 never sees it.So the first commit here just commits that migration — the state a current stable SDK wants — rather than pinning CI to an older Flutter to hide it. Both files get the same block the tool generates; nothing else changes, and
flutter analyzeis still clean on 3.44.Verification
All four jobs pass on this branch. Locally: 106 tests, analyze clean,
dart formatreports 0 of 68 files changed,build_runnerreproduceslib/byte-for-byte, publish dry-run 0 warnings.Worth merging before #7 so that PR picks up checks (it'll need a push or re-run to trigger them).