Merged
Conversation
…ering - Added stringifyValue function to handle various data types for rendering. - Updated InLineOutput and SingleValueRenderer components to use stringifyValue for improved output consistency. - Enhanced test cases to reflect changes in value rendering logic.
…pty output - Modified stringifyValue to return undefined for undefined values instead of converting to a string. - Updated SingleValueRenderer and InLineOutput components to handle the new return type, ensuring empty output is displayed correctly.
- Added VisuallyHidden component to conditionally render the dialog title for improved accessibility. - Updated aria-describedby handling to account for both description and ariaDescription props.
- Introduced context7.json to store URL and public key for integration with context7 services.
… tests - Introduced a check to ensure stringifyValue returns a string, throwing an error if it returns undefined. This enhances test reliability by validating expected output from the stringifyValue function.
- Exported jsonSchemaFormTheme for external use. - Configured MuiPopover to disable portal rendering in the theme. - Updated JsonSchemaForm component to accept a custom theme prop.
Mark type-only imports explicitly across the package so TypeScript can preserve module syntax during builds and tests. Align the default test command with the full Vitest config and add a full-check script for package-wide validation.
Prevent custom renderers from crashing previews and normalize value stringification across JSON, inline output, and sortable tables
- Enhanced jsonSchemaForm theme with MuiPopover configuration. - Added context7 configuration file. - Improved CustomDialog accessibility with a visually hidden title. - Hardened IO preview fallbacks and table rendering in react-flow. - Updated stringifyValue function to handle undefined and empty outputs. - Introduced stringifyValue function for consistent value rendering.
…58827 chore: update build files [skip ci]
Updated the column stringification logic in SortableTable to return "undefined" for undefined values, ensuring consistent rendering in the table header.
Use a shared byte-length helper so padded base64 values and data URIs render the expected size in inline and data views. Keep dialog titles accessible without the extra Radix wrapper and align brittle performance tests with the corrected behavior.
…ules Import renderer and shared component modules directly to reduce barrel coupling and make type-only dependencies explicit.
Track active shortcuts across key transitions so callbacks fire once per press cycle, including space-based shortcuts and updated tests for accessibility, integration, and example flows.
Update the data view renderer test to expect unquoted string output from the current renderer implementation.
Move the initial render mapping state into a dedicated defaults file and use explicit typed context fallbacks to reduce provider coupling.
Handle copy shortcuts in the key handler only when no native text selection is active, so selected nodes copy without breaking input and rendered text copy behavior.
Wrap the fallback dialog title with Radix VisuallyHidden again so accessible titles remain present without relying on custom CSS.
Skip node serialization copy shortcuts for native selections and elements inside nokey regions so tooltip content stays selectable and standard copy behavior still works.
Add a shared retry helper for performance checks and reuse it in the affected tests so timing-based assertions can recover from transient failures between attempts.
…97201 chore: update build files [skip ci]
Restore the barrel import for the color renderer context and remove the unused initial render mappings import from the reducer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.