Skip to content

Wait for the erase to finish before reporting success #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lgnap wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Wait for the erase to finish before reporting success #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 60 additions & 16 deletions krode.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

#include <stdio.h>
#include <string.h>
#include <unistd.h>
#include <hidapi/hidapi.h>

#define RODE_VID 0x19F7
Expand All @@ -25,11 +26,17 @@
#define REPORT_SIZE 17
#define CMD_DELETE 0x4A
#define DELETE_ALL 0x01
#define ACK_OK 0x41
#define DONE_PERCENT 100

/* First reply, then however long the device needs to work through storage. */
#define REPLY_MS 3000
#define PROGRESS_MS 120000

static int delete_recordings(hid_device *dev, unsigned short pid)
{
unsigned char buf[REPORT_SIZE];
int ret;
int ret, percent = -1;

memset(buf, 0, sizeof(buf));
buf[0] = 0x01; /* Report ID */
Expand All @@ -44,21 +51,58 @@ static int delete_recordings(hid_device *dev, unsigned short pid)
return -1;
}

/* Read response - device ACKs with 0x4A 0x41 0x64 */
memset(buf, 0, sizeof(buf));
ret = hid_read_timeout(dev, buf, sizeof(buf), 3000);
if (ret < 0) {
fprintf(stderr, "hid_read failed: %ls\n", hid_error(dev));
return -1;
}
if (ret == 0) {
fprintf(stderr, "Timeout waiting for device response.\n");
return -1;
}

if (buf[1] == CMD_DELETE && buf[2] == 0x41) {
printf("Done. Recordings deleted (status: %d).\n", buf[3]);
return 0;
/*
* The device does not answer once. It streams progress reports,
* 02 4A 41 <percent>, stepping to 100 - byte [3] is a percentage,
* not a status constant. Reading a single reply announces success
* while the erase is still running.
*/
for (;;) {
memset(buf, 0, sizeof(buf));
ret = hid_read_timeout(dev, buf, sizeof(buf),
percent < 0 ? REPLY_MS : PROGRESS_MS);
if (ret <= 0) {
/*
* The transmitter drops off the bus as soon as it is
* done, so losing it after progress has been reported
* is the normal ending, not a failure. Losing it
* before any reply is not.
*/
if (percent < 0) {
if (ret < 0)
fprintf(stderr, "hid_read failed: %ls\n",
hid_error(dev));
else
fprintf(stderr, "Timeout waiting for "
"device response.\n");
return -1;
}
if (isatty(STDOUT_FILENO))
printf("\r");
printf("Device disconnected at %d%% - it re-enumerates "
"when the erase finishes.\n", percent);
return 0;
}

if (buf[1] != CMD_DELETE || buf[2] != ACK_OK)
break; /* unexpected: dump it below */

if (buf[3] != percent) {
percent = buf[3];
/* Overwrite in place on a terminal, stay quiet when
* redirected so logs do not fill with percents. */
if (isatty(STDOUT_FILENO)) {
printf("\r %3d%%", percent);
fflush(stdout);
}
}

if (percent >= DONE_PERCENT) {
if (isatty(STDOUT_FILENO))
printf("\r");
printf("Done. Recordings deleted.\n");
return 0;
}
}

/* Print raw response for debugging */
Expand Down