[codex] Add pipeline-aligned Vector architecture specification#42
[codex] Add pipeline-aligned Vector architecture specification#42sheyuheng wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the Janus Vector Core Architecture Specification, which outlines the design, execution model, and interfaces of the vector execution engine. The review feedback identifies several key areas for improvement, including correcting a binary/hexadecimal prefix typo and expanding the enable mask to 64-bit to match the 64-lane architecture, fixing a grammatical typo in the Chinese text, correcting a mathematical inconsistency in the thread count calculation example, and standardizing the relative alias notation for consistency.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| v.lw [tc, lc0 << 2] -> vt // 加载被除数 | ||
| v.fdiv vt#2, vt#1 -> vt // FP32 除法 | ||
| v.fcvtfp32fp16 vt#1 -> vt // FP32 转 FP16 | ||
| v.sh vt#1, [to0, lc0 << 1] // 存储 FP16 到第 0 个输出 Tile |
There was a problem hiding this comment.
There was a problem hiding this comment.
The original one was correct.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary
Janus/VectorArchitecture impact
Validation
Vector.mdcontentVector_AS.mdand its four referenced imagesgit diff --cached --checkbefore commit