Skip to content

[codex] Add pipeline-aligned Vector architecture specification#42

Open
sheyuheng wants to merge 4 commits into
mainfrom
codex/vector-as-pipeline
Open

[codex] Add pipeline-aligned Vector architecture specification#42
sheyuheng wants to merge 4 commits into
mainfrom
codex/vector-as-pipeline

Conversation

@sheyuheng

Copy link
Copy Markdown
Collaborator

Summary

  • add the Janus Vector Core architecture specification under Janus/Vector
  • align frontend, rename, dispatch, issue, RF read, execute, and TileLSU descriptions with the pipeline diagram
  • document the scalar ALU/BRU, ALU/MUL, and LD/ST address paths
  • include all four images referenced by the specification

Architecture impact

  • defines the SMT4 frontend stages from F0 through D2
  • distinguishes four Vector scheduling domains from the three-compute-uop issue limit
  • specifies shared Hetero-pipe execution resources and the VSTD path
  • uses an 88-entry, 2048-bit Vector RF as the current pipeline baseline
  • unifies Vector-side TileLSU buffering terminology around SCB

Validation

  • verified chapters 1-3 remain identical to the reviewed Vector.md content
  • verified every Markdown image reference resolves to a file included in this PR
  • verified the commit contains only Vector_AS.md and its four referenced images
  • ran git diff --cached --check before commit

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the Janus Vector Core Architecture Specification, which outlines the design, execution model, and interfaces of the vector execution engine. The review feedback identifies several key areas for improvement, including correcting a binary/hexadecimal prefix typo and expanding the enable mask to 64-bit to match the 64-lane architecture, fixing a grammatical typo in the Chinese text, correcting a mathematical inconsistency in the thread count calculation example, and standardizing the relative alias notation for consistency.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docs/architecture/Janus/Vector/Vector_AS.md Outdated
Comment thread docs/architecture/Janus/Vector/Vector_AS.md Outdated
Comment thread docs/architecture/Janus/Vector/Vector_AS.md Outdated
v.lw [tc, lc0 << 2] -> vt // 加载被除数
v.fdiv vt#2, vt#1 -> vt // FP32 除法
v.fcvtfp32fp16 vt#1 -> vt // FP32 转 FP16
v.sh vt#1, [to0, lc0 << 1] // 存储 FP16 到第 0 个输出 Tile

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the relative alias notation ti#N / to#N described in Line 174 and used in Line 220 (to#0), it is recommended to change to0 to to#0.

Suggested change
v.sh vt#1, [to0, lc0 << 1] // 存储 FP16 到第 0 个输出 Tile
v.sh vt#1, [to#0, lc0 << 1] // 存储 FP16 到第 0 个输出 Tile

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original one was correct.

sheyuheng and others added 3 commits June 9, 2026 21:37
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@sheyuheng sheyuheng marked this pull request as ready for review June 9, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants