revise MGATHER/MSCATTER parameter model and add MASK variants#123
Open
bxrbyte wants to merge 1 commit into
Open
revise MGATHER/MSCATTER parameter model and add MASK variants#123bxrbyte wants to merge 1 commit into
bxrbyte wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces documentation for the new MGATHER.MASK and MSCATTER.MASK instructions and provides significant updates to the existing MGATHER and MSCATTER documentation, including new parameters for valid rows/columns and padding values. The review feedback points out that navigation links were added for English documentation files that are missing from the PR, which would result in broken links. Additionally, there is a suggestion to clarify the documentation for MSCATTER.MASK by explicitly referencing the size of the source tile instead of a non-existent Size parameter.
Refine the parameter descriptions for MGATHER and MSCATTER instructions, and introduce documentation for their MASK variants (MGATHER.MASK, MSCATTER.MASK) with per-element predication semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe what this PR changes and why.
Validation
bash tools/ci/check_repo_layout.shpython3 tools/isa/build_golden.py --profile v0.56 --checkpython3 tools/isa/validate_spec.py --profile v0.56python3 tools/isa/check_canonical_v056.py --root .python3 tools/bringup/check_avs_contract.py --matrix avs/linx_avs_v1_test_matrix.yamlpython3 tools/bringup/check_sail_model.pymkdocs build --strictpython3 tools/bringup/check_avs_profile_closure.py --matrix avs/linx_avs_v1_test_matrix.yaml --status avs/linx_avs_v1_test_matrix_status.json --tier prbash tools/regression/run.shSubmodules (if touched)
.gitmodulesURLs remain in the LinxISA org