Fix stale OAuth client registrations - #177
Merged
Merged
Conversation
ランダムなlocalhost callback portに対して、cached Dynamic Client Registrationのredirect URI集合を検証する。互換性がないcacheはauthorization前に再登録し、回帰テストとCI・仕様・利用者向け説明を同期する。
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
github-rag-mcp | 1c193ea | Jul 29 2026, 03:36 AM |
lipluscodex
commented
Jul 29, 2026
lipluscodex
left a comment
Member
Author
There was a problem hiding this comment.
Self-review: PASS
- Acceptance criteria: cached registration is reused only when a non-empty
client_idand registered redirect URI set cover every callback URI requested by the current OAuth flow; stale-port, partial, and malformed caches all force re-registration. - Preserved constraints: random callback port and PKCE S256 remain unchanged; no credential or registration values are logged.
- Verification: proxy 5/5 tests, Worker 75/75 tests, schema drift, TypeScript, dry deploy, package dry-run, and all PR checks passed.
- Docs/CI: English/Japanese requirements, proxy README, and the normal CI path are synchronized.
- Scope deviations: none. The CI file was added to the issue target list before commit so the new regression suite cannot silently fall out of routine checks.
- Next step: auto mode, patch classification; proceed to squash merge after confirming mergeable state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #176
ランダムなlocalhost callback portに対してcached Dynamic Client Registrationのredirect URI互換性を検証し、不一致時はauthorization前に再登録します。
回帰テストを通常CIへ接続し、要求仕様とclient proxy READMEを同期します。
Release type: patch