Skip to content

fix: regenerate Kotlin Wasm yarn lock in dependabot automation - #61

Merged
zigzago merged 1 commit into
mainfrom
fix/wasm-yarn-lock-regeneration
Sep 4, 2026
Merged

fix: regenerate Kotlin Wasm yarn lock in dependabot automation#61
zigzago merged 1 commit into
mainfrom
fix/wasm-yarn-lock-regeneration

Conversation

@zigzago

@zigzago zigzago commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

  • The dependabot-yarn-lock.yml workflow's "Regenerate Kotlin yarn lock" step only ran kotlinUpgradeYarnLock (JS target), never kotlinWasmUpgradeYarnLock (Wasm target).
  • Whenever a dependency bump (e.g. ktor) changed the Wasm target's npm dependency graph, e2e-split/kotlin-js-store/wasm/yarn.lock went stale, and kotlinWasmStoreYarnLock failed the E2E Split-by-client job with Lock file was changed. Run the kotlinWasmUpgradeYarnLock task to actualize lock file.
  • Observed on PR chore: bump ktor from 3.5.0 to 3.5.2 #59 (ktor 3.5.0 → 3.5.2): the workflow ran and committed chore: update Kotlin yarn lock, but only touched the JS lock file, leaving the Wasm lock stale and the job red.
  • Fix: run both kotlinUpgradeYarnLock and kotlinWasmUpgradeYarnLock in that step. The commit step already handled both lock files, it just never got a Wasm-side change to commit.

@zigzago
zigzago force-pushed the fix/wasm-yarn-lock-regeneration branch 2 times, most recently from 42e9ec7 to 2bfaf50 Compare September 4, 2026 08:58
The dependabot-yarn-lock workflow only ran kotlinUpgradeYarnLock (JS),
leaving e2e-split/kotlin-js-store/wasm/yarn.lock stale whenever a
dependency bump changed the Wasm target's npm dependency graph. This
caused kotlinWasmStoreYarnLock to fail in the E2E Split-by-client job
(seen on PR #59 after the ktor bump).
@zigzago
zigzago force-pushed the fix/wasm-yarn-lock-regeneration branch from 2bfaf50 to 8cb46a1 Compare September 4, 2026 08:59
@sonarqubecloud

sonarqubecloud Bot commented Sep 4, 2026

Copy link
Copy Markdown

@zigzago
zigzago merged commit 405d930 into main Sep 4, 2026
8 checks passed
@zigzago
zigzago deleted the fix/wasm-yarn-lock-regeneration branch September 4, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant