Skip to content

fix(linux/pipewire): Add 10-bit RGB formats with 2-bit Alpha to format_map#5088

Open
flibitijibibo wants to merge 1 commit into
LizardByte:masterfrom
flibitijibibo:hdr-blast
Open

fix(linux/pipewire): Add 10-bit RGB formats with 2-bit Alpha to format_map#5088
flibitijibibo wants to merge 1 commit into
LizardByte:masterfrom
flibitijibibo:hdr-blast

Conversation

@flibitijibibo
Copy link
Copy Markdown

Description

The current PipeWire implementation only checks for xBGR2101010 - this isn't always advertised however; KWin for example may only expose formats with alpha:

https://invent.kde.org/plasma/kwin/-/merge_requests/8293/diffs#7390a641bee8f53acd66ba70f27e53b223cfaa18_88_84

With some fixes to the KWin MR, this allows HDR streaming to work with portalgrab:

[2026-05-08 15:15:05.282]: Info: [pipewire] Connected to pipewire version 1.6.4
[2026-05-08 15:15:05.286]: Info: [pipewire] Video format: 87
[2026-05-08 15:15:05.286]: Info: [pipewire] Size: 3840x2160
[2026-05-08 15:15:05.286]: Info: [pipewire] Color primaries: 7
[2026-05-08 15:15:05.286]: Info: [pipewire] Transfer function: 14
[2026-05-08 15:15:05.286]: Info: [pipewire] Framerate (from compositor): 0/1 (variable rate capture)
[2026-05-08 15:15:05.286]: Info: [pipewire] using DMA-BUF buffers
[2026-05-08 15:15:05.286]: Info: [pipewire] Video format: 87
[2026-05-08 15:15:05.286]: Info: [pipewire] Size: 3840x2160
[2026-05-08 15:15:05.286]: Info: [pipewire] Color primaries: 7
[2026-05-08 15:15:05.286]: Info: [pipewire] Transfer function: 14
[2026-05-08 15:15:05.286]: Info: [pipewire] Framerate (from compositor): 0/1 (variable rate capture)
[2026-05-08 15:15:05.286]: Info: [pipewire] using DMA-BUF buffers
[2026-05-08 15:15:05.292]: Info: [pipewire] Using negotiated Resolution: 3840x2160

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher added this to the pipewire milestone May 9, 2026
@Kishi85
Copy link
Copy Markdown
Contributor

Kishi85 commented May 13, 2026

I'm lacking the necessary HDR hardware but after testing at least I can't see any regressions for SDR with this applied.

Maybe @garnacho or someone else can comment on HDR? Otherwise this change is looking good to me.

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Bundle Report

Bundle size has no change ✅

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.83%. Comparing base (0709990) to head (4166ab1).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5088      +/-   ##
==========================================
- Coverage   17.86%   17.83%   -0.03%     
==========================================
  Files         111      111              
  Lines       24005    24005              
  Branches    10619    10619              
==========================================
- Hits         4289     4282       -7     
+ Misses      18169    15542    -2627     
- Partials     1547     4181    +2634     
Flag Coverage Δ
Archlinux 11.23% <ø> (ø)
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.37% <ø> (+0.01%) ⬆️
Homebrew-ubuntu-22.04 13.58% <ø> (ø)
Linux-AppImage 12.16% <ø> (ø)
Windows-AMD64 14.84% <ø> (ø)
Windows-ARM64 13.23% <ø> (-0.01%) ⬇️
macOS-arm64 19.03% <ø> (ø)
macOS-x86_64 18.39% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/pipewire.cpp 0.00% <ø> (ø)

... and 50 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0709990...4166ab1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants