Skip to content

fix(audio): fix install of Steam Streaming Speakers driver#5125

Merged
ReenigneArcher merged 2 commits into
LizardByte:masterfrom
andygrundman:andyg.fix-steam-driver-install
May 16, 2026
Merged

fix(audio): fix install of Steam Streaming Speakers driver#5125
ReenigneArcher merged 2 commits into
LizardByte:masterfrom
andygrundman:andyg.fix-steam-driver-install

Conversation

@andygrundman
Copy link
Copy Markdown
Contributor

Description

The Steam driver install code was accidentally ifdef'ed out of existence by a recent refactor.

This of course only fixes x64, I don't know what the arm64 users are supposed to do.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher
Copy link
Copy Markdown
Member

ReenigneArcher commented May 15, 2026

That's my bad. I broke it in #4791

There is no arm version as far as I'm aware.

@ReenigneArcher ReenigneArcher added this to the stable release milestone May 15, 2026
@ReenigneArcher ReenigneArcher force-pushed the andyg.fix-steam-driver-install branch from f003644 to ee97496 Compare May 15, 2026 22:55
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Bundle Report

Bundle size has no change ✅

Comment thread src/platform/windows/audio.cpp Outdated
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 New Code Smells (required ≤ 0)
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@e72e684). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5125   +/-   ##
=========================================
  Coverage          ?   17.84%           
=========================================
  Files             ?      111           
  Lines             ?    24065           
  Branches          ?    10640           
=========================================
  Hits              ?     4295           
  Misses            ?    15538           
  Partials          ?     4232           
Flag Coverage Δ
Archlinux 11.23% <ø> (?)
FreeBSD-14.3-amd64 13.36% <ø> (?)
Homebrew-ubuntu-22.04 13.58% <ø> (?)
Linux-AppImage 12.15% <ø> (?)
Windows-AMD64 14.89% <ø> (?)
Windows-ARM64 13.23% <ø> (?)
macOS-arm64 18.99% <ø> (?)
macOS-x86_64 18.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/windows/audio.cpp 25.93% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72e684...e1b9b2d. Read the comment docs.

@ReenigneArcher ReenigneArcher merged commit 2cd7ba3 into LizardByte:master May 16, 2026
72 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants