Skip to content

test: refactor tests to use parameterized it.each() #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 1 commit into from
Jul 13, 2026
Merged

test: refactor tests to use parameterized it.each() #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 28 additions & 29 deletions tests/crowdin-progress.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,25 +665,30 @@ describe('generateProjectSvg', () => {
expect(content).toContain('#71C277');
});

it('omits the translation bar when approvalProgress is 100', () => {
const entries = [makeEntry({ translationProgress: 100, approvalProgress: 100 })];
generateProjectSvg('Proj', entries, SVG_TEST_OUT);
const [, content] = fs.writeFileSync.mock.calls[0];
expect(content).not.toContain('#5D89C3');
});

it('omits background track when translationProgress is 100', () => {
const entries = [makeEntry({ translationProgress: 100, approvalProgress: 50 })];
generateProjectSvg('Proj', entries, SVG_TEST_OUT);
const [, content] = fs.writeFileSync.mock.calls[0];
expect(content).not.toContain('opacity="0.3"');
});

it('omits approval bar when approvalProgress is 0', () => {
const entries = [makeEntry({ translationProgress: 50, approvalProgress: 0 })];
it.each([
{
name: 'omits the translation bar when approvalProgress is 100',
translationProgress: 100,
approvalProgress: 100,
unexpectedContent: '#5D89C3',
},
{
name: 'omits background track when translationProgress is 100',
translationProgress: 100,
approvalProgress: 50,
unexpectedContent: 'opacity="0.3"',
},
{
name: 'omits approval bar when approvalProgress is 0',
translationProgress: 50,
approvalProgress: 0,
unexpectedContent: '#71C277',
},
])('$name', ({ translationProgress, approvalProgress, unexpectedContent }) => {
const entries = [makeEntry({ translationProgress, approvalProgress })];
generateProjectSvg('Proj', entries, SVG_TEST_OUT);
const [, content] = fs.writeFileSync.mock.calls[0];
expect(content).not.toContain('#71C277');
expect(content).not.toContain(unexpectedContent);
});

it('generates an empty SVG body when entries is empty', () => {
Expand Down Expand Up @@ -1671,19 +1676,13 @@ describe('main', () => {
expect(mockPaginate).not.toHaveBeenCalled();
});

it('still generates SVG graphs', async () => {
await main();
expect(console.log).toHaveBeenCalledWith(expect.stringContaining('SVG graphs'));
});

it('logs the SVG-only mode message', async () => {
await main();
expect(console.log).toHaveBeenCalledWith(expect.stringContaining('SVG-only'));
});

it('completes successfully without GitHub credentials', async () => {
it.each([
{ name: 'still generates SVG graphs', logMessage: 'SVG graphs' },
{ name: 'logs the SVG-only mode message', logMessage: 'SVG-only' },
{ name: 'completes successfully without GitHub credentials', logMessage: 'Sync complete' },
])('$name', async ({ logMessage }) => {
await main();
expect(console.log).toHaveBeenCalledWith(expect.stringContaining('Sync complete'));
expect(console.log).toHaveBeenCalledWith(expect.stringContaining(logMessage));
});
});
});