chore(deprivatize): scrub Vista codename and Libraxis org references#2
chore(deprivatize): scrub Vista codename and Libraxis org references#2m-szymanska wants to merge 6 commits into
Conversation
…ifact symlinks
Drop docs/ARCHITECTURE_{ACTUAL,COMPARISON,PROMISED}.md: internal session
status snapshots reconstructing the private deployment (host names, launchd
labels, port topology) — not part of the public docs surface (docs/index.html).
Remove .vibecrafted/{plans,reports} symlinks that pointed into a private home
artifact tree and were tracked despite the /.vibecrafted gitignore rule.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ders Replace personal names and emails (Maciej/Monika/Klaudiusz, void@div0.space, the1st@whoai.am), 'M&K' and 'The LibraxisAI Team' credit lines with the collective 'vetcoders' / hello@vetcoders.io across package metadata, LICENSE, CI/workflow headers, hook scripts, docs footers, and the changelog. Normalize camelCase brand 'VetCoders' to 'Vetcoders' (lowercase in the git URL). Replace a private shared-volume path in the configuration example with a neutral path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ests Replace the private host name 'dragon' with neutral placeholders in CLI/API doc-comment examples and in query-router/keyword-extraction test inputs (intent and filtering semantics preserved; tests still pass). Replace a real home path in a keyword-extraction test fixture with a neutral path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rename for_vista() -> for_app_optimized() (no callers), genericize Vista project/codename in fixtures, docs and CLI help to neutral names, switch ai.libraxis.* launchd label to ai.vetcoders.*, drop LibraxisShare path and LibraxisAI copyright line. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request performs a comprehensive rebranding and cleanup across the codebase, replacing specific references to "Vista", "Dragon", and "The LibraxisAI Team" with generic terms like "Demo", "laptop", and "Vetcoders". Key changes include renaming MemexEngine::for_vista() to MemexEngine::for_app_optimized(), updating documentation, and removing architecture comparison markdown files. The review feedback suggests a minor simplification in src/engine.rs to remove a redundant db_path setting that already matches the default fallback behavior.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| app_name: "app".to_string(), | ||
| namespace: "default".to_string(), | ||
| db_path: Some("~/.rmcp-servers/vista/lancedb".to_string()), | ||
| db_path: Some("~/.rmcp-servers/app/lancedb".to_string()), |
There was a problem hiding this comment.
Since app_name is set to "app", the db_path will automatically default to "~/.rmcp-servers/app/lancedb" via effective_db_path(). Explicitly setting db_path here is redundant and can be simplified to None.
| db_path: Some("~/.rmcp-servers/app/lancedb".to_string()), | |
| db_path: None, |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 228e2ba2ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| app_name: "app".to_string(), | ||
| namespace: "default".to_string(), | ||
| db_path: Some("~/.rmcp-servers/vista/lancedb".to_string()), | ||
| db_path: Some("~/.rmcp-servers/app/lancedb".to_string()), |
There was a problem hiding this comment.
When this helper was Vista-specific, a fixed store was expected, but the rename turns it into the README's generic optimized constructor. Every caller now gets the same app name, namespace, and ~/.rmcp-servers/app/lancedb; two unrelated applications that adopt for_app_optimized() will share searches, upserts, and deletes in the same namespace, unlike for_app(app_name, namespace). Consider accepting app/namespace parameters or keeping a domain-specific compatibility helper so optimized users remain isolated.
Useful? React with 👍 / 👎.
| launchctl bootstrap gui/$$(id -u) $(LAUNCHD_PLIST) 2>/dev/null || \ | ||
| launchctl kickstart gui/$$(id -u)/ai.libraxis.rust-memex 2>/dev/null || \ | ||
| launchctl kickstart gui/$$(id -u)/ai.vetcoders.rust-memex 2>/dev/null || \ | ||
| $(INSTALL_PATH) serve --db-path $(DB_PATH) --http-port $(HTTP_PORT) --http-only & \ |
There was a problem hiding this comment.
On macOS upgrades where the existing LaunchAgent is still installed as ~/Library/LaunchAgents/ai.libraxis.rust-memex.plist, this rebrand makes make start miss it: bootstrap now points at the new plist path and kickstart targets the new service label, while launchctl's documented form is kickstart [-kp] service-target (man page). With no migration or old-label fallback in this recipe, the command falls through to an unmanaged background rust-memex serve, losing the launchd lifecycle users previously configured.
Useful? React with 👍 / 👎.
Two things CI (clippy -D warnings + tests on latest stable) flagged on this
branch:
1. The de-privatization scrub renamed the project_id-match test inputs
inconsistently: the asserted-positive case checked project_id "Loctree"
against filter "vetcoders", which can never match. Restored to a consistent
positive match ("Loctree" vs "loctree"); the matcher logic itself
(matches_project_filter / metadata_matches_project) was never touched.
2. Pre-existing clippy debt the newer stable enforces: unnecessary_sort_by
(-> sort_by_key with Reverse, behaviour-identical) and collapsible match
guards. Machine-applicable autofixes + the equivalent sort_by_key rewrites.
Behaviour unchanged: clippy/fmt clean, full test suite (lib+bins+tests) passes.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Line 636 in 493d942
Replace residual private hostnames in README
In this scrubbed public README section, the lead-in now uses generic machines, but the per-host bullet immediately below still publishes the old concrete hostnames (dragon, mgbook16). That leaves the same private machine identifiers visible in the main user-facing docs after the deprivatization pass, so please replace these suffix examples with generic hostnames as well.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - **Moved to Loctree org:** `https://github.com/VetCoders/rmcp-memex` → `https://github.com/Loctree/rust-memex`. Docs, install CTAs, and issue tracker URLs updated across README, docs/, install.sh, and Makefile. | ||
| - **Authors + license unchanged.** Maciej Gad & Monika Szymanska remain the Cargo authors; dual MIT OR Apache-2.0 license retained for library-friendly downstream use. | ||
| - **Moved to Loctree org:** `https://github.com/vetcoders/rmcp-memex` → `https://github.com/Loctree/rust-memex`. Docs, install CTAs, and issue tracker URLs updated across README, docs/, install.sh, and Makefile. | ||
| - **Authors + license unchanged.** Vetcoders remains the Cargo author; dual MIT OR Apache-2.0 license retained for library-friendly downstream use. |
There was a problem hiding this comment.
This line says authors and license are unchanged, but this same commit changes Cargo.toml to authors = ["Vetcoders <hello@vetcoders.io>"], and the package/license file advertise BUSL-1.1 rather than MIT/Apache. For release consumers checking attribution or licensing, the changelog now gives incorrect compliance guidance; please either document the author metadata change and BUSL license or remove the claim.
Useful? React with 👍 / 👎.
Same cross-platform clippy issue as the sibling repo: the cfg'd non-macOS early return makes the macOS ioreg body unreachable, which CI's clippy -D warnings on ubuntu promotes to an error (macOS builds never compile the early return). Scope the allow to non-macOS. Pre-existing, not from the de-privatization scrub. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 participant
Deprivatize pass + second-pass residual scrub for public-release hygiene.
A read-only leak audit flagged residual private fingerprints the initial sweep
missed. This PR removes them:
MemexEngine::for_vista()->for_app_optimized()(no in-tree callers).Vistaproject/codename across fixtures, docs and CLI help.ai.libraxis.*launchd label ->ai.vetcoders.*./Volumes/LibraxisSharepath andLibraxisAIcopyright line.cargo check --libgreen afterward. Brand/product identifiers (loctree,vetcoders, rust-memex) intentionally retained.
Note (out of scope here): README/API still use a veterinary/medical domain in
examples (
patient_id, SOAP notes,MetaFilter::for_patient). That is an APIdesign surface already published on crates.io, left untouched pending a
separate decision.
🤖 Generated with Claude Code