Skip to content

chore(deprivatize): scrub private references for public release#2

Open
m-szymanska wants to merge 4 commits into
mainfrom
chore/deprivatize
Open

chore(deprivatize): scrub private references for public release#2
m-szymanska wants to merge 4 commits into
mainfrom
chore/deprivatize

Conversation

@m-szymanska

Copy link
Copy Markdown

Deprivatize pass for public-release hygiene: scrub private references
(personal names, operator paths, private org/infra fingerprints) per the
cross-repo cleanup.

Verified by a read-only leak audit over tracked files at HEAD: no residual
personal names, operator home paths, host names, tailnet IPs, private
endpoints, or secrets. Brand/product identifiers (vetcoders, loctree, etc.)
intentionally retained.

🤖 Generated with Claude Code

m-szymanska and others added 2 commits June 28, 2026 20:22
Replace personal author names and private email (Maciej Gad
<void@div0.space>, Monika Szymanska) with the collapsed org identity
"vetcoders <hello@vetcoders.io>" in Cargo.toml and the CHANGELOG entry
that mirrors it. Normalize the historical camelCase brand URL
(VetCoders -> vetcoders) and repoint changelog commit links from the
private LibraxisAI org to the canonical public Loctree/rust-mux repo.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Replace private LibraxisAI org references with the canonical public
Loctree/rust-mux repo in the README install snippet and install.sh
(REPO_URL + curl line), and change the sample launchd label from the
private com.libraxis.* domain to com.loctree.rust-mux.*.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates repository URLs, author metadata, and launchd labels to reflect the rebranding of the project to rust-mux under the Loctree organization. While these updates are correct, several references to the old binary name rust_mux (with an underscore) remain in the installation script, launchd plist template, and README. These remaining references will cause installation and execution failures, and should be updated to use the hyphenated rust-mux name.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tools/install.sh
CARGO_HOME=${CARGO_HOME:-"$HOME/.cargo"}
CARGO_BIN="$CARGO_HOME/bin"
REPO_URL="https://github.com/LibraxisAI/rust_mux"
REPO_URL="https://github.com/Loctree/rust-mux"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While updating the repository URL is correct, the installation script will fail because it still references rust_mux (with an underscore) instead of the rebranded rust-mux (with a hyphen).

Specifically:

  • Line 34: cargo install ... rust_mux needs to be rust-mux because cargo install expects the package name defined in Cargo.toml.
  • Line 36: installed_bin="$CARGO_BIN/rust_mux" needs to be rust-mux because the compiled binary name defaults to the package name.

Please update these references in the script to ensure the installation works correctly.

<dict>
<key>Label</key>
<string>com.libraxis.mcp-mux.general-memory</string>
<string>com.loctree.rust-mux.general-memory</string>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The plist template still references /Users/YOUR_USER/.cargo/bin/rust_mux (with an underscore) on line 11. Since the package has been rebranded to rust-mux (with a hyphen), the compiled binary will be named rust-mux.

Please update line 11 to use rust-mux so that launchd can locate and execute the binary correctly:

<string>/Users/YOUR_USER/.cargo/bin/rust-mux</string>

Additionally, consider renaming this file from rmcp_mux.sample.plist to rust-mux.sample.plist to match the new branding.

Comment thread README.md
## Install (curl | sh)
```
curl -fsSL https://raw.githubusercontent.com/LibraxisAI/rust_mux/main/tools/install.sh | sh
curl -fsSL https://raw.githubusercontent.com/Loctree/rust-mux/main/tools/install.sh | sh

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Throughout the README, the binary is referred to as rust_mux (with an underscore) in the usage examples and paths (e.g., ./target/release/rust_mux, rust_mux wizard, etc.).

Since the package name in Cargo.toml has been rebranded to rust-mux (with a hyphen), the compiled binary will actually be named rust-mux. Please update the README examples to use rust-mux to avoid confusing users who copy-paste the commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e355170062

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tools/install.sh
CARGO_HOME=${CARGO_HOME:-"$HOME/.cargo"}
CARGO_BIN="$CARGO_HOME/bin"
REPO_URL="https://github.com/LibraxisAI/rust_mux"
REPO_URL="https://github.com/Loctree/rust-mux"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Match cargo install target to the public crate

When this script is fetched from the new Loctree/rust-mux repository, it still later runs cargo install ... rust_mux; cargo install --help says the trailing [CRATE] selects the package from the given source, and this repo's metadata reports package/binaries rust-mux and rust-mux-proxy, not rust_mux. The documented curl | sh path therefore fails with could not find rust_mux (and would also check the wrong installed binary path) instead of installing from the public repo.

Useful? React with 👍 / 👎.

m-szymanska and others added 2 commits June 28, 2026 23:49
The latest stable clippy flags a collapsible match guard in wizard.rs that the
code predates; CI runs clippy with -D warnings. Machine-applicable autofix.
Pre-existing, not from the de-privatization scrub. Behaviour unchanged: clippy
clean, cargo test passes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The coverage upload hard-failed (if-no-files-found: error) because current
cargo-tarpaulin writes lcov.info, not tarpaulin-report.lcov. Match both names so
the artifact uploads regardless of tarpaulin version. fmt/clippy/tests already
pass; this was the only red step. Pre-existing, unrelated to the scrub.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant