This repository was archived by the owner on Dec 14, 2023. It is now read-only.
Commented a log taking up LogCat space#57
Open
enkemari wants to merge 1 commit intoLogentriesCommunity:masterfrom
Open
Commented a log taking up LogCat space#57enkemari wants to merge 1 commit intoLogentriesCommunity:masterfrom
enkemari wants to merge 1 commit intoLogentriesCommunity:masterfrom
Conversation
Contributor
|
I would be in favour of removing this code rather then commenting it out. |
Author
|
I really actually don't mind if the line is completely removed or commented out. It's taking over our LogCat and we cannot debug like this. We're pulling the code into our project until we can use the online library as a standalone gradle import (as one is supposed to). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a line in lib/src/main/java/com/logentries/logger/LogStorage.java logging the current size of the cached logs while the mobile device was offline. This log took over the LogCat completely not allowing for any proper debugging. Very irritating. It was probably useful to someone else, but for us, it was just a burden. I've only changed it into a comment allowing others to still find it and uncomment it for their own debugging purposes.