Fix limit and yakuman tenpai flags calculation#36
Open
umbralOptimatum wants to merge 3 commits intoLonghorn-Riichi:mainfrom
Open
Fix limit and yakuman tenpai flags calculation#36umbralOptimatum wants to merge 3 commits intoLonghorn-Riichi:mainfrom
umbralOptimatum wants to merge 3 commits intoLonghorn-Riichi:mainfrom
Conversation
Flags.YOU_HAD_LIMIT_TENPAI and Flags.YOU_REACHED_YAKUMAN_TENPAI were supposed to check that their waits weren't dead. Instead they required that at least one tile from the wait was already visible on the board.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed calculation for Flags.YOU_HAD_LIMIT_TENPAI and Flags.YOU_REACHED_YAKUMAN_TENPAI. Instead of checking to exclude dead waits as intended, they were excluding waits without visible tiles on the table. I've fixed this and made them properly count concealed tiles in hand and red fives.
I also replaced some calls to deprecated protobuf methods that the Python library no longer supports.