Skip to content

Conversation

@noellehmcheng
Copy link
Contributor

Description

📝 Thanks for contributing to map2loop!
Please describe the issue that this pull request addresses and summarize the changes you are implementing.
Include relevant motivation and context, if appropriate.
List any new dependencies that are required for this change.

Fixes #(issue)

Type of change

  • Documentation update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Test improvement

How Has This Been Tested?

Please describe any tests that you ran to verify your changes.
Provide branch name so we can reproduce.

Checklist:

  • This branch is up-to-date with master
  • All gh-action checks are passing
  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My tests run with pytest from the map2loop folder
  • New and existing tests pass locally with my changes

Checklist continued (if PR includes changes to documentation)

  • I have built the documentation locally with make.bat
  • I have built this documentation in docker, following the docker configuration in map2loop/docs
  • I have checked my spelling and grammar

@noellehmcheng
Copy link
Contributor Author

  • specify gdal version as 3.4.3 for windows python 3.10
  • put gdal installation prior to other dependencies, removed duplicated gdal in dependencies.txt
  • fixed path in map2loop/init.py such that it correctly loads dependencies.txt
  • added try except block for shapely.dwithin() to handle older geos versions

These changes collectively fix issues that cause failures in windows python 3.9 and 3.10 and macos python 3.9

@noellehmcheng noellehmcheng changed the base branch from master to 3.2.3_dev June 16, 2025 05:17
@lachlangrose lachlangrose merged commit 2deffb5 into 3.2.3_dev Jun 16, 2025
13 checks passed
@noellehmcheng noellehmcheng deleted the noelle/testing branch July 14, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants