fix: RetroAchievements identification for custom Paks and multi-system emulators - #775
Merged
Merged
Conversation
apommel
changed the title
Member
|
Looks good to me, what do you think @clintonium-119? |
|
LGTM 💯 |
frysee
force-pushed
the
ra-console-autodetect
branch
2 times, most recently
from
July 19, 2026 17:00
0c5b48d to
1cb683b
Compare
frysee
force-pushed
the
ra-console-autodetect
branch
from
July 19, 2026 22:22
1cb683b to
569fb39
Compare
Member
Author
|
@frysee I consent to have this contribution and any future contribution relicensed to Polyform Noncommercial License 1.0. I'll also put it in the dedicated issue. |
frysee
approved these changes
Jul 20, 2026
carroarmato0
added a commit
to carroarmato0/NextUI
that referenced
this pull request
Jul 26, 2026
… pak fixes New upstream features merged: - Color palettes: 18 bundled palettes + user-loadable palette dir (LoveRetro#787) - FN1/FN2/HOME can now launch user-assigned tool paks (LoveRetro#788) - Keep device awake while connected as USB gadget (LoveRetro#783) - RetroAchievements identification for custom paks and multi-system emulators (LoveRetro#775) - Brick Pro rumble limited to 2.5V (was 3.3V, too strong) - Align Brick/Pro rumble strength Conflict resolutions (C++20 branch vs upstream): - nextui.cpp: kept RAII core::SurfacePtr, took upstream THEME_COLOR7 for preview fill - minput.c: kept GFX_getFonts() and pad-> accessors, took upstream button rendering (ALT_BUTTON_TEXT_COLOR, text_color local, GFX_blitAssetColor, THEME_COLOR2 for sticks) - tg5040 platform.c: accepted conditional MAX_VOLTAGE for Brick Pro; RUMBLE_PATH not needed (branch uses deviceModel->rumble_gpio_path from DeviceDescriptor)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the RetroAchievements integration relies on a mapping of the NextUI emulator tags (in
ra_consoles.h) to identify the running console and then the game. If the console is not detected, the integration stops the identification. There are a few cases in which this approach can cause issues:At the same time, rcheevos is able to auto-detect the console from the game when using the console ID
RC_CONSOLE_UNKNOWN.This PR improves the detection logic. It maintains the console mapping by emulator, preserving the existing behaviour. However, when the console cannot be detected from the mapping, the detection will not fail directly and will instead be handled by rcheevos by passing RC_CONSOLE_UNKNOWN.
Because of this, the
RA_initMemoryRegionscall was moved fromra_do_load_gametora_game_loaded_callback. There was a comment saying that the memory regions must be initialized before loading the game, but as far as I could test, this is not the case.