feat(player): ship desktop smart shelf MVP - #122
Open
Lowband21 wants to merge 6 commits into
Open
Conversation
Deploying ferrex with
|
| Latest commit: |
d471f4b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bc64bd38.ferrex.pages.dev |
| Branch Preview URL: | https://ferrex-issue-low-651.ferrex.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
SMART_SHELF_SAVEcontract (/intelligence/smart-shelves/drafts/{artifact_id}/save) so the desktop/API save path reaches the save handler.ferrex-player-intelligencereducer crate for composer state, provider fallback, progress/cancel handling, draft editing, save confirmation, and retry/recovery flows while preserving player crate boundaries.Summary
Ships the desktop smart-shelf MVP end to end: a desktop user can open a grounded shelf composer, monitor generation progress, review and adjust a typed draft, save it through the shared player/server API contract as a private manual collection, and land on the saved collection detail page for browsing.
Testing
jj git fetch --remote origin— passed withNothing changed; the issue stack root parent matchesdev@origin(f7ef04f).cargo fmt --all --check— passed.nix develop .#ferrex-player --command env cargo check --workspace --all-targets— passed; emitted existingferrexctlmissing-docs warnings.nix develop .#ferrex-player --command env cargo test -p ferrex-core --lib— passed, 294 tests.nix develop .#ferrex-player --command env cargo test -p ferrex-player-api --lib -- --nocapture— passed, 12 tests.nix develop .#ferrex-player --command env cargo test -p ferrex-server routes::v1::tests::smart_shelf_save_route_matches_api_contract -- --nocapture— passed; verifies POST on the shared save path reaches the save route.nix develop .#ferrex-player --command env cargo test -p ferrex-server --test intelligence_routes smart_shelf -- --nocapture— not runnable in this worker becauseDATABASE_URLis unset forsqlx::test; the route tests compile under the workspace all-targets check.nix develop .#ferrex-player --command env cargo test -p ferrex-player-intelligence --lib— passed, 14 tests.nix develop .#ferrex-player --command env cargo test -p ferrex-player-ui --test collections_tab— passed, 12 tests.nix develop .#ferrex-player --command env cargo test -p ferrex-player-ui --test smart_shelf_flow— passed, 8 tests.nix develop .#ferrex-player --command env cargo test -p ferrex-player-app smart_shelf_mvp -- --nocapture— passed 2 focused unit tests plussmart_shelf_mvp_start_draft_save_opens_collection_detail_fixture.nix develop .#ferrex-player --command env cargo test -p ferrex-player-app screenshot::visual_qa::tests -- --nocapture— passed 5 visual QA matrix tests.nix develop .#ferrex-player --command env cargo test -p ferrex-player-app --test smart_shelf_mvp— passed../scripts/check-player-crate-boundaries.sh— passed.nix develop .#ferrex-player --command env cargo run -p ferrex-player --profile priority -- screenshot matrix smart-shelf list— listed all 8 MVP visual QA cases.nix develop .#ferrex-player --command env cargo run -p ferrex-player --profile priority -- screenshot matrix smart-shelf --dry-run --only state:collection-error— listed the collection-error case.nix develop .#ferrex-player --command env cargo run -p ferrex-player --profile priority -- screenshot matrix smart-shelf --output-dir target/ui-screenshots/smart-shelf-mvp— captured 8 screenshots andtarget/ui-screenshots/smart-shelf-mvp/smart-shelf-mvp-visual-qa-matrix.json.jj_conflict_reportandjj log -r '(::(ferrex/issue/LOW-651) & ~::(dev@origin)) & conflicts()'— no conflicted commits in submitted history.rg -n '^(<<<<<<<|>>>>>>>)' Cargo.toml Cargo.lock crates docs scripts— no conflict markers found.jj st— clean working copy on an empty commit aboveferrex/issue/LOW-651.