Skip to content

feat(player): ship desktop smart shelf MVP - #122

Open
Lowband21 wants to merge 6 commits into
devfrom
ferrex/issue/LOW-651
Open

feat(player): ship desktop smart shelf MVP#122
Lowband21 wants to merge 6 commits into
devfrom
ferrex/issue/LOW-651

Conversation

@Lowband21

Copy link
Copy Markdown
Owner

Changes

  • Adds typed smart-shelf server contracts and player API/service/stub support for provider readiness, run lifecycle, cancellation, draft validation, save, and conflict recovery.
  • Wires smart-shelf saves through a server POST route registered on the shared SMART_SHELF_SAVE contract (/intelligence/smart-shelves/drafts/{artifact_id}/save) so the desktop/API save path reaches the save handler.
  • Adds the UI-agnostic ferrex-player-intelligence reducer crate for composer state, provider fallback, progress/cancel handling, draft editing, save confirmation, and retry/recovery flows while preserving player crate boundaries.
  • Adds the Iced desktop smart-shelf entry points, composer/review/progress/save surfaces, and browse-first collection detail behavior without replacing exact catalog Search or adding Android/TV, Home pinning, chatbot, or playback queue management changes.
  • Adds deterministic fake-provider MVP coverage, an 8-state screenshot/visual QA matrix, and developer docs for provider setup, boundaries, recovery states, and QA workflow.

Summary

Ships the desktop smart-shelf MVP end to end: a desktop user can open a grounded shelf composer, monitor generation progress, review and adjust a typed draft, save it through the shared player/server API contract as a private manual collection, and land on the saved collection detail page for browsing.

Testing

  • jj git fetch --remote origin — passed with Nothing changed; the issue stack root parent matches dev@origin (f7ef04f).
  • cargo fmt --all --check — passed.
  • nix develop .#ferrex-player --command env cargo check --workspace --all-targets — passed; emitted existing ferrexctl missing-docs warnings.
  • nix develop .#ferrex-player --command env cargo test -p ferrex-core --lib — passed, 294 tests.
  • nix develop .#ferrex-player --command env cargo test -p ferrex-player-api --lib -- --nocapture — passed, 12 tests.
  • nix develop .#ferrex-player --command env cargo test -p ferrex-server routes::v1::tests::smart_shelf_save_route_matches_api_contract -- --nocapture — passed; verifies POST on the shared save path reaches the save route.
  • nix develop .#ferrex-player --command env cargo test -p ferrex-server --test intelligence_routes smart_shelf -- --nocapture — not runnable in this worker because DATABASE_URL is unset for sqlx::test; the route tests compile under the workspace all-targets check.
  • nix develop .#ferrex-player --command env cargo test -p ferrex-player-intelligence --lib — passed, 14 tests.
  • nix develop .#ferrex-player --command env cargo test -p ferrex-player-ui --test collections_tab — passed, 12 tests.
  • nix develop .#ferrex-player --command env cargo test -p ferrex-player-ui --test smart_shelf_flow — passed, 8 tests.
  • nix develop .#ferrex-player --command env cargo test -p ferrex-player-app smart_shelf_mvp -- --nocapture — passed 2 focused unit tests plus smart_shelf_mvp_start_draft_save_opens_collection_detail_fixture.
  • nix develop .#ferrex-player --command env cargo test -p ferrex-player-app screenshot::visual_qa::tests -- --nocapture — passed 5 visual QA matrix tests.
  • nix develop .#ferrex-player --command env cargo test -p ferrex-player-app --test smart_shelf_mvp — passed.
  • ./scripts/check-player-crate-boundaries.sh — passed.
  • nix develop .#ferrex-player --command env cargo run -p ferrex-player --profile priority -- screenshot matrix smart-shelf list — listed all 8 MVP visual QA cases.
  • nix develop .#ferrex-player --command env cargo run -p ferrex-player --profile priority -- screenshot matrix smart-shelf --dry-run --only state:collection-error — listed the collection-error case.
  • nix develop .#ferrex-player --command env cargo run -p ferrex-player --profile priority -- screenshot matrix smart-shelf --output-dir target/ui-screenshots/smart-shelf-mvp — captured 8 screenshots and target/ui-screenshots/smart-shelf-mvp/smart-shelf-mvp-visual-qa-matrix.json.
  • jj_conflict_report and jj log -r '(::(ferrex/issue/LOW-651) & ~::(dev@origin)) & conflicts()' — no conflicted commits in submitted history.
  • rg -n '^(<<<<<<<|>>>>>>>)' Cargo.toml Cargo.lock crates docs scripts — no conflict markers found.
  • jj st — clean working copy on an empty commit above ferrex/issue/LOW-651.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 30, 2026

Copy link
Copy Markdown

Deploying ferrex with  Cloudflare Pages  Cloudflare Pages

Latest commit: d471f4b
Status: ✅  Deploy successful!
Preview URL: https://bc64bd38.ferrex.pages.dev
Branch Preview URL: https://ferrex-issue-low-651.ferrex.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant