Skip to content

Rebase/upstream master 0.14 - #1

Open
Lowband21 wants to merge 1 commit into
masterfrom
rebase/upstream-master-0.14
Open

Rebase/upstream master 0.14#1
Lowband21 wants to merge 1 commit into
masterfrom
rebase/upstream-master-0.14

Conversation

@Lowband21

Copy link
Copy Markdown
Owner

The core team is busy and does not have time to mentor nor babysit new contributors. If a member of the core team thinks that reviewing and understanding your work will take more time and effort than writing it from scratch by themselves, your contribution will be dismissed. It is your responsibility to communicate and figure out how to reduce the likelihood of this!

Read the contributing guidelines for more details: https://github.com/iced-rs/iced/blob/master/CONTRIBUTING.md

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread wgpu/src/lib.rs
Comment on lines +716 to +720
primitive_storage.render_layer_batches(
layer_index,
&mut render_pass,
&resources,
scissor_rect,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Batched primitives rendered after all other primitives

Batched custom primitives are skipped during the per-instance loop because BlackBox::draw returns true for batched types, but all batched work is only rendered later in a single call to render_layer_batches (see wgpu/src/lib.rs lines 716-720). This means any batched primitive is always drawn after every other primitive in the layer, regardless of its original order. When a batched primitive should appear behind or between other primitives (e.g., when some instances are not batchable and fall back to the normal path), their z-order is inverted and they will overdraw later items. The render order regression affects every layer that mixes batched and non-batched primitives.

Useful? React with 👍 / 👎.

@Lowband21
Lowband21 force-pushed the rebase/upstream-master-0.14 branch from 1a7bd73 to eabf093 Compare December 24, 2025 04:18
Signed-off-by: Grayson Hieb <grayson@lowband.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant