fix: present Wayland subtitles on media clock - #1
Merged
Conversation
Treat a zero start position as no explicit resume target so opening from the beginning does not issue a redundant flushing seek. Also keep HTTP header context values in the string form GStreamer expects.
Add the media-time subtitle scheduler, PGS decoder, text renderer, and Wayland subtitle runtime payload types used to queue decoded cues before presenting them on UI ticks.
Bind wp-color-management-v1 when available, tag HDR video surfaces with stream colorimetry, keep subtitle buffers in the compositor default sRGB space, and keep subtitle subsurface commits synchronized with the parent.
Defer waylandsink display/window setup to the bus sync handler, keep subtitle stream IDs out of playbin3 SelectStreams, schedule subtitle presentation from demuxer probes, and resume only after the target seek AsyncDone is observed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wayland subtitles now present from media running time through a clean linear commit series on top of
main. The branch keeps the manually-added follow-up fixes: HDR surface tagging, x-raw entity decoding, and PGS cue persistence until an explicit clear display set.Changes
Testing
cargo fmt --all --check— passed.cargo test -p subwave_wayland subtitle_scheduler --all-features— passed, 10 tests.cargo test -p subwave_wayland pgs --all-features— passed, 8 tests.cargo test -p subwave_wayland subtitle_entities --all-features— passed, 1 test.