fix(ci): remove unused Iced image codecs - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
imagefrom the workspaceicedfeature set, leavingadvanced,wgpu,thread-pool,wayland-hack, andwaylandenabled.Cargo.locksoimage,ravif,rav1e,bitstream-io,core2, and related codec-only transitive crates are no longer in the resolved dependency graph.Summary
Subwave no longer enables Iced’s unused image feature, so the workspace avoids the AVIF/rav1e codec dependency chain that introduced the yanked/unmaintained
core2advisory while preserving the required WGPU, Wayland, and appsink playback features.Testing
cargo deny check advisories— passed.cargo audit— passed; it now reports only the existing allowedpasteunmaintained warning fromwgpu/metal.cargo deny check— passed; duplicate-version findings remain warnings.cargo tree -i core2andcargo tree -i image— both reported no matching package in the resolved graph.The configured clippy step completed successfully; it still emits pre-existing
collapsible_matchwarnings insubwave_appsink/src/video_player.rsandsubwave_wayland/src/pipeline.rsbecause the gate uses-W warnings.