Stop the README example numbers contradicting the measured table - #29
Merged
Conversation
The header example borrowed packaging's function count (408) while showing an input count an order of magnitude below the 184,592 in the results table, so the two disagreed with each other. It is an illustration, so it now uses numbers that are plainly its own. Also anchored the measured table: recorded-input counts move with the library version, and re-recording sqlparse on a later commit gives 16,321 inputs across the same 141 functions. A number a reader cannot reconcile is worse than no number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header example borrowed packaging's function count (408) while showing
an input count an order of magnitude below the 184,592 in the results table,
so the two disagreed with each other. It is an illustration, so it now uses
numbers that are plainly its own.
Also anchored the measured table: recorded-input counts move with the library
version, and re-recording sqlparse on a later commit gives 16,321 inputs
across the same 141 functions.
A number a reader cannot reconcile is worse than no number.