ci: run self-hosted GPU tests on fork PRs (behind run approval)#363
Merged
Conversation
The same-repo guard skipped the RTX 3090 and gfx1151 jobs for every fork PR, silently dropping the strongest signal this CI produces exactly where review needs it most (outside contributions). The repo already enforces approval_policy=all_external_contributors, so no fork code can run anywhere (hosted or self-hosted) until a maintainer inspects the push and approves the run. Rely on that human checkpoint instead of skipping the GPU jobs outright. Co-Authored-By: WOZCODE <contact@withwoz.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gpu-tests(RTX 3090, sm_86) andgpu-tests-amd(Radeon 8060S, gfx1151) jobs were guarded to same-repo PRs, so fork PRs (e.g. #349) skipped both — losing the only real-hardware signal exactly where it matters most.This removes the same-repo guard and relies on the repo's existing
approval_policy=all_external_contributors: every fork push parks asaction_requireduntil a maintainer reviews and approves the run, for hosted and self-hosted jobs alike. Nothing runs on lucebox3 without a human green-light.workflow_dispatchno longer needed as an escape hatch (jobs run on the PR event itself)lucebox3-gpu-runnerconcurrency group (serialized on the single box)🧙 Built with WOZCODE