⚡ Bolt: [performance improvement] Terminal search fast-path#337
⚡ Bolt: [performance improvement] Terminal search fast-path#337Lucenx9 wants to merge 2 commits into
Conversation
This avoids slice overhead and zipping iterators for the vast majority of search iterations where the first character does not even match. Co-authored-by: Lucenx9 <185146821+Lucenx9@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 10 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe terminal search match loop now checks the needle’s first character separately before comparing the remaining characters, replacing the previous full-window comparison at each candidate position. ChangesTerminal search
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This avoids slice overhead and zipping iterators for the vast majority of search iterations where the first character does not even match. Co-authored-by: Lucenx9 <185146821+Lucenx9@users.noreply.github.com>
💡 What: Added a fast path to
for_each_char_match_startinterminal_search.rsto check the first character of the needle before slicing and setting up iterators for the full substring match.🎯 Why: Terminal search is case-insensitive and operates over millions of characters in the scrollback buffer. Zipping iterators and performing character-by-character checks for every position is expensive.
📊 Impact: Significantly reduces CPU overhead during searches by early-exiting the vast majority of search positions where the first character doesn't even match.
🔬 Measurement: Can be verified by running the search benchmarks or noticing reduced latency when searching in a large terminal buffer.
PR created automatically by Jules for task 9335067029242793073 started by @Lucenx9
Improves case-insensitive terminal search performance by checking the needle’s first character before slicing and scanning the remaining substring. This reduces iterator and slice overhead for large scrollback buffers without changing search behavior.
No GTK/VTE, socket/core API, test, or security/privacy changes.