Skip to content

⚡ Bolt: [performance improvement] Terminal search fast-path#337

Open
Lucenx9 wants to merge 2 commits into
mainfrom
bolt-terminal-search-optimization-9335067029242793073
Open

⚡ Bolt: [performance improvement] Terminal search fast-path#337
Lucenx9 wants to merge 2 commits into
mainfrom
bolt-terminal-search-optimization-9335067029242793073

Conversation

@Lucenx9

@Lucenx9 Lucenx9 commented Jul 13, 2026

Copy link
Copy Markdown
Owner

💡 What: Added a fast path to for_each_char_match_start in terminal_search.rs to check the first character of the needle before slicing and setting up iterators for the full substring match.
🎯 Why: Terminal search is case-insensitive and operates over millions of characters in the scrollback buffer. Zipping iterators and performing character-by-character checks for every position is expensive.
📊 Impact: Significantly reduces CPU overhead during searches by early-exiting the vast majority of search positions where the first character doesn't even match.
🔬 Measurement: Can be verified by running the search benchmarks or noticing reduced latency when searching in a large terminal buffer.


PR created automatically by Jules for task 9335067029242793073 started by @Lucenx9

Improves case-insensitive terminal search performance by checking the needle’s first character before slicing and scanning the remaining substring. This reduces iterator and slice overhead for large scrollback buffers without changing search behavior.

No GTK/VTE, socket/core API, test, or security/privacy changes.

This avoids slice overhead and zipping iterators for the vast majority
of search iterations where the first character does not even match.

Co-authored-by: Lucenx9 <185146821+Lucenx9@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Lucenx9, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 10 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0a96039e-740b-4ce3-a865-7a0a6cad8a08

📥 Commits

Reviewing files that changed from the base of the PR and between fda0686 and afd09d8.

📒 Files selected for processing (2)
  • crates/forktty-ui-gtk/src/gtk_app/terminal_input.rs
  • crates/forktty-ui-gtk/src/socket_cli.rs
📝 Walkthrough

Walkthrough

The terminal search match loop now checks the needle’s first character separately before comparing the remaining characters, replacing the previous full-window comparison at each candidate position.

Changes

Terminal search

Layer / File(s) Summary
First-character match scanning
crates/forktty-ui-gtk/src/gtk_app/terminal_search.rs
for_each_char_match_start uses a case-insensitive first-character check before zipping the remaining needle and haystack characters.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: frontend, rust

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the performance-focused terminal search change and is concise and descriptive.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Privacy Boundary ✅ Passed Only a local search hot-path changed; no telemetry, network, or new persistence code was added, and existing search cache behavior is unchanged.
Terminal Command Safety ✅ Passed PR only changes crates/forktty-ui-gtk/src/gtk_app/terminal_search.rs; no PTY, socket, shell, packaging, or notification command-execution code was touched.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bolt-terminal-search-optimization-9335067029242793073

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This avoids slice overhead and zipping iterators for the vast majority
of search iterations where the first character does not even match.

Co-authored-by: Lucenx9 <185146821+Lucenx9@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant