Sentiment model fix#118
Open
douglaschu wants to merge 2 commits into
Open
Conversation
Updated torch and transformers version constraints to fix sentiment analysis
Owner
|
Hi! This seems fine. However it's marked as draft/WIP, do you intend me to review it or are you still making changes? Thanks! |
Author
|
Hi Luis, I marked it as a draft as I meant to double-check it one last time before submitting. Wasn't able to come back to it until now. It's ready to submit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: The sentiment model fails to load with the current dependency versions.
Cause: Torch v1.13.1 is too old for current HuggingFace Transformers. Also, Transformers starting at v4.49 introduced a CVE check that requires Torch v2.6 or later.
Fix: Update Torch to v2.2 to fix runtime compatibility with the sentiment model pipeline. Added a <4.49 upper bound on Transformers to prevent breaking changes introduced in that version, pinning it.
Testing: Verified end-to-end by deploying my own build of the Ace Attorney bot for Bluesky running on the Objection Engine. Sentimental analysis produces expected assignments of emotions to characters throughout rendered video output.