docs: clarify database migration workflow and RPC trust boundary - #339
Merged
Lost-Z merged 1 commit intoAug 31, 2026
Merged
Conversation
Fixes Lumen-Scribe#276 by adding a Database changes section to CONTRIBUTING.md that documents how to create migrations, apply them, and regenerate sqlx metadata. Covers the full workflow for schema changes including updating triggers. Fixes Lumen-Scribe#275 by making the trust boundary explicit in simulate_call and /simulate endpoint docs. Clarifies that while Lumenqraph doesn't sign or broadcast, the safety guarantee depends on the RPC endpoint's simulation semantics and could change with future Soroban upgrades. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
@williamsokperez-arch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #275
closes #276
Fixes #276 by adding a Database changes section to CONTRIBUTING.md that documents how to create migrations, apply them, and regenerate sqlx metadata. Covers the full workflow for schema changes including updating triggers.
Fixes #275 by making the trust boundary explicit in simulate_call and /simulate endpoint docs. Clarifies that while Lumenqraph doesn't sign or broadcast, the safety guarantee depends on the RPC endpoint's simulation semantics and could change with future Soroban upgrades.
Description
Fixes #
Changes
Pre-submit checklist
make fmt(orcargo fmt --all)make lint(orcargo clippy --workspace --all-targets -- -D warnings)make test(orcargo test --workspace)cargo auditandcargo deny check(if dependencies changed)migrations/(if schema changed)Testing
Additional context