Skip to content

GH-818 Chunked Responses Review 1#716

Closed
dnwiebe wants to merge 23 commits into
masterfrom
GH-818-StreamKey
Closed

GH-818 Chunked Responses Review 1#716
dnwiebe wants to merge 23 commits into
masterfrom
GH-818-StreamKey

Conversation

@dnwiebe

@dnwiebe dnwiebe commented Oct 1, 2025

Copy link
Copy Markdown
Collaborator

Note

Refactors routing/return-route handling by embedding IDs in Route, consolidating per-stream state in ProxyServer, simplifying APIs (no separate return-route messages), and updating neighborhood/route structures, utilities, and tests accordingly.

  • Core routing/protocol:
    • Embed return-route IDs in Route (set_return_route_id, return_route_id); remove separate ID passing.
    • ExpectedServices::RoundTrip no longer carries an ID; add hostname_opt to RouteQueryResponse.
    • Remove AddReturnRouteMessage; eliminate related plumbing.
  • ProxyServer:
    • Introduce StreamInfo map to track tunneled_host, DNS-retry, route, protocol, TTL; generate per-request return-route IDs; retire old maps.
    • Rework DNS failure handling, retries, and stream key purge scheduling; logging tweaks.
  • Neighborhood/Route:
    • Adjust zero-hop and multi-hop route responses to new shapes; propagate hostname.
    • Update ExpectedService helpers (accessors for keys/wallets/rates).
  • Utilities:
    • TtlHashMap: add retire-closure and remove; timing/cleanup changes.
    • StreamKey::make_meaningless_stream_key now random.
    • Rename HTTP framer logger to HttpPacketFramer.
  • Tests/fixtures:
    • Widespread updates removing return_route_id parameters, adding stream_key, and aligning with new APIs and behaviors.
    • Minor cleanups (e.g., string/port handling) and .gitignore tweak.

Written by Cursor Bugbot for commit 3798177. This will update automatically on new commits. Configure here.

Comment thread multinode_integration_tests/tests/connection_termination_test.rs
Comment thread multinode_integration_tests/tests/connection_termination_test.rs
Comment thread multinode_integration_tests/tests/connection_termination_test.rs Outdated
Comment thread multinode_integration_tests/tests/connection_termination_test.rs Outdated
Comment thread multinode_integration_tests/tests/self_test.rs
Comment thread node/src/sub_lib/http_packet_framer.rs
Comment thread node/src/sub_lib/neighborhood.rs Outdated
Comment thread node/src/sub_lib/proxy_server.rs
Comment thread node/src/sub_lib/route.rs Outdated
Comment thread node/src/sub_lib/route.rs Outdated
Comment thread node/src/sub_lib/ttl_hashmap.rs
Comment thread node/src/neighborhood/mod.rs Outdated
Comment thread node/src/neighborhood/mod.rs Outdated
Comment thread node/src/neighborhood/mod.rs
Comment thread node/src/proxy_server/mod.rs Outdated
Comment thread node/src/proxy_server/mod.rs
Comment thread node/src/proxy_server/mod.rs Outdated
Comment thread node/src/proxy_server/mod.rs Outdated
Comment thread node/src/proxy_server/mod.rs
Comment thread node/src/proxy_server/mod.rs Outdated
Comment thread node/src/proxy_server/mod.rs Outdated
Comment thread node/src/proxy_server/mod.rs Outdated
Comment thread node/src/proxy_server/mod.rs Outdated
Comment thread node/src/proxy_server/mod.rs
Comment thread node/src/proxy_server/mod.rs Outdated

@dnwiebe dnwiebe left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resume at proxy_server.rs:3258 green

Comment thread node/src/proxy_server/mod.rs
Comment thread node/src/proxy_server/mod.rs
Comment thread node/src/proxy_server/mod.rs Outdated
Comment thread node/src/proxy_server/mod.rs
Comment thread node/src/proxy_server/mod.rs Outdated
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Comment thread node/src/proxy_server/protocol_pack.rs
Comment thread node/src/neighborhood/mod.rs
Comment thread node/src/neighborhood/mod.rs
Comment thread node/src/proxy_server/client_request_payload_factory.rs
Comment thread node/src/proxy_server/client_request_payload_factory.rs
Comment thread node/src/proxy_server/mod.rs
Comment thread node/src/proxy_server/mod.rs
Comment thread node/src/proxy_server/mod.rs
Comment thread node/src/proxy_server/mod.rs
Comment thread node/src/proxy_server/mod.rs
Comment thread node/src/sub_lib/neighborhood.rs
Comment thread node/src/sub_lib/ttl_hashmap.rs
@dnwiebe dnwiebe closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants