fix: prevent disabled pagination buttons from triggering navigation

[ashishSoni1234]

The shared PaginationLink renders an tag, so the native disabled attribute/CSS pseudo-class never applied, and CustomPagination only set aria-disabled (a screen-reader hint) while leaving onClick unguarded - clicking Previous on page 1 or Next on the last page still pushed an out-of-range page via router.push.

PaginationLink now accepts a disabled prop that guards onClick, removes the element from tab order (tabIndex=-1), and sets aria-disabled for assistive tech. CustomPagination passes disabled based on the current page and clamps createPageURL as a defense-in-depth backstop.

Adds Vitest + React Testing Library (previously no test setup existed) with regression tests for both the shared primitive and the consumer.

[vercel]

@ashishSoni1234 is attempting to deploy a commit to the MAY55A's projects Team on Vercel.

A member of the Team first needs to authorize it.

[MAY55A]

@ashishSoni1234, thank you for your effort!

However, adding tests and setting up a test framework is out of scope for this issue.

There is another open issue (#12) addressing tests configuration, you can work on that one if you'd like, then you can come back to this issue and proceed with the pagination tests.

But for now, it would be more helpful to just fix the pagination issue in the already existing files.

[ashishSoni1234]

Hi @MAY55A the test framework and test files have been removed in the
latest commit the PR now only contains the pagination fix in the
existing files (src/components/ui/pagination.tsx and
src/components/custom/pagination.tsx). Could you please re-review?
i am excited to do any further changes if needed

[MAY55A]

@ashishSoni1234 , thank you for removing the test setup part !

The pagination issue seems to be almost fixed, but there is this case that triggers a problem, you can reproduce it this way:

1. add manually page=2 as a URL param (in discussions page for example)
2. the page shows no items (no discussions for example)
3. previous button is enabled and clickable
4. however, when clicking previous no action is triggered

The case is not only for a page value of 2 but for all values greater than totalPages or less than 0

The problem is that the UI of the button shows something different from its actual behavior (looks clickable but triggers no action), it should reflect exactly what it does.

To address this problem from its root, try fixing the out-of-range problem (when currentPage < 1 or currentPage > totalPages) by doing this:

• make sure that currentPage is always a valid value (between 1 and totalPages)
• change the out-of-range page value in the URL param to always show a valid value (rewrite the URL param without redirecting when necessary)
• make sure no UI shows a non-valid value

I believe these changes will make the pagination mechanism more robust and prevent any unwanted behaviors in the future.

If you notice any other unexpected behaviors, don't hesitate to address them as well !

[ashishSoni1234]

@MAY55A thanks for catching that! Pushed a fix — currentPage is now
clamped into [1, totalPages] in a single place, and the displayed
page number, Previous/Next disabled state, and click targets all derive
from that same clamped value, so the UI can never show a state that
doesn't match its actual behavior. When the raw ?page value is out of
range (e.g. page=2 with only 1 total page, or negative/huge values),
an effect rewrites the URL to the clamped value via router.replace
(no extra history entry, no hard redirect).

Verified manually with page=2/0/-5/very-large values against 1-page and
0-page (empty) result sets — buttons now stay disabled exactly when they
should, and the URL self-corrects. Ready for another look whenever
you get a chance.

[MAY55A]

@ashishSoni1234, thank you for your work !

The issue seems to be fixed, when testing on the discussions page.

However, on the projects page, there seems to be a problem, though it seems like a server/DB side issue, but it does reflect on the front and prevents the display of the pagination buttons.

It would be of great help, if you could investigate the problem further, try starting with console logs to see what's causing it.

Thank you greatly for you dedication and hard work !

[MAY55A]

Use ?? instead of || to make sure rawPage can keep its original 0 value, so the URL param can be changed and updated to 1 (currently ?page=0 is allowed in the URL)