Feature: Add TDI TreeShr functions used by mdsthin#3065
Open
WhoBrokeTheBuild wants to merge 1 commit into
Open
Feature: Add TDI TreeShr functions used by mdsthin#3065WhoBrokeTheBuild wants to merge 1 commit into
WhoBrokeTheBuild wants to merge 1 commit into
Conversation
When implementing the thin Tree class for mdsthin, I needed these functions from the TDI stdlib. Currently, they're implemented on the fly when called, but they should be added to the stdlib so other things can use them. TreeFindNodeWildRelative operates much like TreeFindNodeWild, but relative to a node TreeGetRecordSerialized returns the serialized data for a node TreeDecompileRecord returns the decompiled data for a node Once these are included, mdsthin can check the server version and only implement them on the fly as needed
WhoBrokeTheBuild
requested review from
heidthecamp,
joshStillerman,
mwinkel-dev and
santorofer
WhoBrokeTheBuild
added
feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When implementing the thin Tree class for mdsthin, I needed these functions from the TDI stdlib. Currently, they're implemented on the fly when called, but they should be added to the stdlib so other things can use them.
TreeFindNodeWildRelativeoperates much likeTreeFindNodeWild, but relative to a nodeTreeGetRecordSerializedreturns the serialized data for a nodeTreeDecompileRecordreturns the decompiled data for a nodeOnce these are included, mdsthin can check the server version and only implement them on the fly as needed