Skip to content

Build: Add tests for package installs#3067

Open
WhoBrokeTheBuild wants to merge 3 commits into
alphafrom
slw-test-package-install
Open

Build: Add tests for package installs#3067
WhoBrokeTheBuild wants to merge 3 commits into
alphafrom
slw-test-package-install

Conversation

@WhoBrokeTheBuild

@WhoBrokeTheBuild WhoBrokeTheBuild commented Jul 10, 2026

Copy link
Copy Markdown
Member

Add "Test Packages" stage to Jenkinsfile
Add a new flag to build.py, --test-package-install, which must be run with/after --package. This will create a stock docker container and attempt to install the packages and then do a small test
Add --dockerimage-target to build.py to be used with --test-package-install
Add --dockerimage-target to most debian/redhat/windows .opts files
Standardize --platform in all updated .opts files

Refactor build.py to avoid duplicating the code in do_docker

  • Add run_docker to handle most docker-related functions
  • Add get_redhat_package_version/get_exe_version for converting 1.2.3 -> 1.2-3 version formats

@WhoBrokeTheBuild WhoBrokeTheBuild self-assigned this Jul 10, 2026
@WhoBrokeTheBuild WhoBrokeTheBuild added build Relates to the build system test This is a need for, or an addition to the tests labels Jul 10, 2026
@mwinkel-dev

Copy link
Copy Markdown
Contributor

HI @WhoBrokeTheBuild -- I'm curious why the two new Ubuntu 26 *.opts files did not also need changing. Were they omitted from this PR because their changes are in a different PR?

mwinkel-dev
mwinkel-dev previously approved these changes Jul 10, 2026

@mwinkel-dev mwinkel-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the *.opts files are straightforward.

The most complex change was the refactoring of build.py. The review used a diff of that file in the slw-test-package-install branch with that in the alpha branch. A careful comparison shows that code blocks were moved around but none were dropped. There were also some minor code cleanup changes.

Summary is that these changes match the PR's description. It is excellent that automated install tests are part of the build process.

NOTE: Eventually the two new Ubuntu 26 *.opt files should also add the "test installer" arguments. That can be done after this PR is merged.

santorofer
santorofer previously approved these changes Jul 10, 2026

@santorofer santorofer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and I have seen it being testing and working correctly.

Add "Test Packages" stage to Jenkinsfile
Add a new flag to build.py, --test-package-install, which must be run with/after --package. This will create a stock docker container and attempt to install the packages and then do a small test
Add --dockerimage-target to build.py to be used with --test-package-install
Add --dockerimage-target to most debian/redhat/windows .opts files
Standardize --platform in all updated .opts files
Refactor build.py to avoid duplicating the code in do_docker
* Add run_docker to handle most docker-related functions
* Add get_redhat_package_version/get_exe_version for converting 1.2.3 -> 1.2-3 version formats
@WhoBrokeTheBuild WhoBrokeTheBuild dismissed stale reviews from santorofer and mwinkel-dev via 55c67ca July 13, 2026 17:23
@WhoBrokeTheBuild WhoBrokeTheBuild force-pushed the slw-test-package-install branch from c4b9735 to 55c67ca Compare July 13, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Relates to the build system test This is a need for, or an addition to the tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants