Fix: Remove trailing scalar dimensions from signals too in TdiSubscript#3071
Open
merlea wants to merge 2 commits into
Open
Fix: Remove trailing scalar dimensions from signals too in TdiSubscript#3071merlea wants to merge 2 commits into
merlea wants to merge 2 commits into
Conversation
Contributor
|
The next post is for the Jenkins build system. |
Contributor
|
Retest this please |
Contributor
Author
|
Not sure if this is linked, but I think I forgot to push the last commit with the test changes (although the logs on this PR are not really showing this). The branch should now be up-to-date. |
Contributor
|
Retest this please |
Contributor
|
Hi @merlea -- This PR is timing out on all Ubuntu / Debian arm64 platforms. |
Contributor
|
Hi @merlea -- Turns out that our arm64 "builder" was down. It is being rebooted and we'll then we build your PR again. |
WhoBrokeTheBuild
requested review from
WhoBrokeTheBuild,
mwinkel-dev and
santorofer
July 16, 2026 17:53
WhoBrokeTheBuild
previously approved these changes
Jul 16, 2026
merlea
force-pushed
the
subscript-signal-remove-trailing-scalar-dimensions
branch
from
July 17, 2026 07:07
43860a8 to
9cbf050
Compare
merlea
force-pushed
the
subscript-signal-remove-trailing-scalar-dimensions
branch
from
July 17, 2026 07:15
9cbf050 to
b1d77ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3069.
TdiSubscripton a signal, the number of dimensions of the resulting signal cannot exceed the number of dimensions of its data.