Fix: Convert date string to english locale in java setViewDate method#3072
Open
merlea wants to merge 1 commit into
Open
Fix: Convert date string to english locale in java setViewDate method#3072merlea wants to merge 1 commit into
merlea wants to merge 1 commit into
Conversation
Contributor
|
The next post is for the Jenkins build system |
Contributor
|
Retest this please |
1 similar comment
Contributor
|
Retest this please |
Contributor
|
Weird that Jenkins won't rebuild this PR. Will try again later today. |
Contributor
|
Retest this please |
1 similar comment
Contributor
|
Retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
java/mdsobjects/tests/MDSplus.MdsTreeTesttest would fail on my system due to the locale settings. Converting the locale toen_USallowed the test to pass. This PR allows the test to pass with any locale.setViewDatemethod sinceLibConvertDateStringexpects thisjava.timepackage tools in place of deprecatedjava.util.Date,... as recommended by JDK.