Skip to content

fix: restore earth-tone palette eaten by PR #30 merge#32

Merged
madsCodeBuddy merged 2 commits intomainfrom
fix/restore-earth-tones-after-merge
Apr 29, 2026
Merged

fix: restore earth-tone palette eaten by PR #30 merge#32
madsCodeBuddy merged 2 commits intomainfrom
fix/restore-earth-tones-after-merge

Conversation

@madsCodeBuddy
Copy link
Copy Markdown
Collaborator

Summary

The merge of PR #30 (refactor) resolved its conflict with PR #28 (earth tones) by taking the refactor branch's old ENERGY_COLORS values, reverting #28's palette in the dict. The CSS footer link color (#7A8C5C) was preserved, leaving the file inconsistent: legend swatches and ellipse fills use the old palette while the page accent uses the new one.

Fix

Restore earth-tone palette in ENERGY_COLORS and regenerate HTML:

Energy type Reverted to Restored
Chemical #0F793D #7A8C5C (olive)
Radiative #FFCC33 #E5C16E (warm sand)
Thermal #CC3333 #7B3F3F (deep rust)
Mechanical #336699 #4F6B82 (slate)

Same palette and colorblind-safety reasoning as #28 (Machado et al. 2009 CVD simulation, all pairwise luminance gaps ≥20).

Files changed

  • docs/build_desert_farm.py (4 lines)
  • docs/desert_farm_stommel.html regenerated (size unchanged: 219,746 B)

Verified

  • black + flake8 clean
  • No stragglers of old palette in either file
  • HTML now contains all 4 earth-tone hexes, zero old-palette hexes

The merge of PR #30 (refactor) resolved its conflict with PR #28 (earth
tones) by taking the refactor branch's old ENERGY_COLORS values
(#0F793D / #FFCC33 / #CC3333 / #336699), reverting #28's earth-tone
palette in the dict. The CSS footer link color was preserved as
#7A8C5C, leaving the file in an inconsistent state where the legend
swatches and ellipse fills used the old palette while the page accent
used the new one.

Restoring the earth-tone palette and regenerating the HTML:

  Chemical   #0F793D -> #7A8C5C  (olive)
  Radiative  #FFCC33 -> #E5C16E  (warm sand)
  Thermal    #CC3333 -> #7B3F3F  (deep rust)
  Mechanical #336699 -> #4F6B82  (slate)

Same palette and same colorblind-safety reasoning as PR #28.
The page header had 'chemical (green), radiative (gold), thermal
(red), mechanical (blue)' baked into the prose. After the palette
change to olive/sand/rust/slate, that text would describe colors
that no longer match the rendered ellipses.
@madsCodeBuddy madsCodeBuddy merged commit f4cd79a into main Apr 29, 2026
4 checks passed
@madsCodeBuddy madsCodeBuddy deleted the fix/restore-earth-tones-after-merge branch April 29, 2026 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant