Feature/working branch#2
Draft
rochellechann wants to merge 3 commits intomainfrom
Draft
Conversation
rochellechann
commented
Jul 8, 2021
| cartResponse: [], | ||
| }; | ||
|
|
||
| public [CartAction.REQUEST_PRODUCT](state: ICartState, action: IAction<CartResponseModel>): any { |
Collaborator
Author
There was a problem hiding this comment.
Need to update the type as CartResponseModel instead of any.
rochellechann
commented
Jul 8, 2021
| }; | ||
| } | ||
|
|
||
| public [CartAction.REQUEST_PRODUCT_FINISHED](state: ICartState, action: IAction<CartResponseModel>): any { |
Collaborator
Author
There was a problem hiding this comment.
Need to update the type as CartResponseModel instead of any.
rochellechann
commented
Jul 8, 2021
| } | ||
|
|
||
| return !Array.isArray(response.data) ? new Model(response.data) : (response.data.map((json) => new Model(json)) as any); | ||
| return !Array.isArray(response.data) ? new Model(response.data.data) : (response.data.map((json) => new Model(json)) as any); |
Collaborator
Author
There was a problem hiding this comment.
We can just this on the api side so its not too nested with the response that comes back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is a working branch that adds a new cart reducer to retrieve product information from the cart. I also removed some files that we do not use at the moment so make it more simplified.