Remove Boost dependency, upgrade to C++20 - #179
Merged
Merged
Conversation
png++ 0.2.9 is unmaintained (2015) and broken with modern libc++. Since we only used it for simple "create image, set pixels, write PNG" operations, replace it with a ~150 line header-only wrapper around libpng directly. This removes the libs/png++-0.2.9 dependency.
- Add devbox.json with all C++ build dependencies
- CMakeLists.txt: fall back to find_package(Protobuf) when the
vendored protobuf build is not present, remove Boost static lib requirement, handle GLEW target name differences across platforms
- Update Boost.Asio usage for 1.87+: io_service -> io_context,
resolver::query removal, expires_from_now -> expires_after,
io_context.post -> boost::asio::post
- Update protobuf usage: ByteSize() -> ByteSizeLong()
- Fix unique_ptr<Derived> -> shared_ptr<Base> conversion for newer libc++ strictness
- Fix png_write.h: add missing <fstream> include, fix const_cast
- Add CLAUDE.md and update README with devbox build instructions
macOS only supports GLSL 150+ (OpenGL 3.2 Core profile), not GLSL 130. The shaders already used modern syntax so only the version directive needed updating. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Modern GCC/libstdc++ no longer transitively includes <algorithm> through other standard library headers, causing build failures for std::find, std::find_if, std::sort, std::clamp, etc.
Add path-change detection to build-protobuf.sh so moving the repo automatically triggers a clean rebuild instead of failing with stale libtool paths.
The bug had no current callers but would produce wrong bounds for any non-square rectangle.
CMake now generates a run.sh wrapper on Linux that prepends system lib paths so the Nix-built binary can find the GPU driver. Updated README with consolidated Linux/macOS build instructions and devbox setup.
Drop the Boost.Filesystem dependency in favor of the C++17 standard library equivalent. Add missing #include <cassert> in RadiansAngle.cpp and gaf_test.cpp where it was previously provided transitively via Boost headers.
Use a standard table-driven CRC32 with polynomial 0xEDB88320, identical output to Boost.CRC and zlib. Add tests with known reference values to verify correctness.
… helper Add rwe::hashCombine in util/hash_combine.h, using the same algorithm as Boost (golden ratio constant 0x9e3779b9). Replace all boost::hash and boost::hash_combine usage in Point, DiscreteRect, GameMediaDatabase, and test files. Remove unused hash_value ADL function from Point. Add missing includes exposed by removing transitive Boost headers.
Add rwe::SpanStream, a lightweight std::istream wrapper over a const char* buffer with full seek support. Replaces all boost::interprocess::bufferstream usage across the codebase. Add tests covering sequential reads, seeking, boundary conditions, and binary data.
Also fixes a bug where --dir-features was mapped to pathMapping.downloads instead of pathMapping.features.
Replace the vendored spdlog 0.14.0 (which was incompatible with C++20) with a minimal SimpleLogger using LOG_XXX << stream macros. Log level is controlled at compile time via RWE_LOG_LEVEL. Also upgrades the C++ standard from C++17 to C++20 (gcc/clang and MSVC).
…, upload-artifact v6, cache v5, setup-python v6)
NSIS is not pre-installed on windows-2025 runners but WiX is. Precompiled headers for librwe speed up builds across all platforms. ccache added for Linux and MinGW CI builds with GitHub Actions cache.
Switch rapidcheck submodule from MHeasell fork to upstream emil-e/rapidcheck (the fork had no custom changes). Updates from 2023 to Feb 2026, picking up std::aligned_storage removal, C++20 fixes, and cmake_minimum_required bump to 3.16. Rename LICENSE to LICENSE.txt for WiX installer compatibility.
Catch2 v3 is a compiled library instead of header-only, reducing test compilation overhead by ~80%. Key changes: - Link Catch2::Catch2WithMain instead of defining CATCH_CONFIG_MAIN - Replace catch2/catch.hpp with catch2/catch_test_macros.hpp - Add catch2/catch_approx.hpp where Approx is used - Qualify Approx as Catch::Approx (no longer in global namespace) - Remove MSVC _HAS_DEPRECATED_RESULT_OF workaround (fixed in rapidcheck) - Disable RC_ENABLE_CATCH to avoid target collision with Catch2 v3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
boost::filesystem→std::filesystemboost::program_options→ simpleOpaqueArgsparserboost::interprocess::bufferstream→SpanStreamboost::hash_combine→ inlinehash_combinehelper withstd::hashboost::crc_32_type→ standalone CRC32 implementationboost::adaptors→std::viewsand structured bindingsboost::asio→ standalone Asio (header-only submodule)spdlogwith minimalSimpleLogger(~150 lines) to fix C++20 incompatibilitypng++with minimallibpngwrapperDiscreteRect::bottom()bug (returnedy + widthinstead ofy + height)#include <algorithm>across 31 source filesTest plan
🤖 Generated with Claude Code