fix a py2 compat issue in neonatal_cortex.py #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was testing for "stringiness" with `isinstance(str)`, but this only works with py3. Instead, test for "functionness" with `callable(x)`. This was deprecated in py3.1, but has been undeprecated for py3.2+, so it's safer and simpler. https://bugs.python.org/issue10518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was testing for "stringiness" with
isinstance(str), but this onlyworks with py3.
Instead, test for "functionness" with
callable(x). This was deprecatedin py3.1, but has been undeprecated for py3.2+, so it's safer and
simpler.
https://bugs.python.org/issue10518